Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vViuQ-006lED-02 for pgpool-hackers@arkaria.postgresql.org; Wed, 17 Dec 2025 04:13:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vViuP-009xfr-04 for pgpool-hackers@arkaria.postgresql.org; Wed, 17 Dec 2025 04:13:05 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vViuO-009xfk-2l for pgpool-hackers@lists.postgresql.org; Wed, 17 Dec 2025 04:13:05 +0000 Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vViuM-001AD8-2p for pgpool-hackers@lists.postgresql.org; Wed, 17 Dec 2025 04:13:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=postgresql.org; s=20171124; h=Content-Transfer-Encoding:Content-Type: Mime-Version:References:In-Reply-To:From:Subject:To:Message-Id:Date:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=fcuV8T2bmsrQVNj6o8AAw4WbWhUU5+oRBhurJJEcvRw=; b=wSZnISj3w1gl2oI8AlEINsNRQD lhAvWT0b0w0fC/Q3ljk7Q8riCJcqA4Nuh0RlfQoyFUkVHEF5NNDPW2YMKSWYPeremCP4WmBSVJ1Bf 6qyBHdlfX8CGMZefTq1NARB5ybPAw2HkwFUlnv1NFtpr4iEKsRBfRXMCOkikxoY7xZBLCmgOA4Azg Ryaxy6C0CSoFunS/y/4OYPOLFczXkrafkzxrTxI5W4rx84TFDtmYIz7Ku2AD1YGdLn3sSSDKbuA3x AAFDf+/3At7TGruoZ67pFjCURHFhz8jpA6ZEavyHxfya0MFHZqNz8cM0i2FUdFzdc9dhu4A3oA+ni AFtf/nvg==; Received: from [2409:11:4120:300:60bd:dbaa:488:1e49] (helo=localhost) by meldrar.postgresql.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vViuK-0028is-21 for pgpool-hackers@lists.postgresql.org; Wed, 17 Dec 2025 04:13:02 +0000 Date: Wed, 17 Dec 2025 13:12:50 +0900 (JST) Message-Id: <20251217.131250.1502848575535780879.ishii@postgresql.org> To: pgpool-hackers@lists.postgresql.org Subject: Re: Refactor BackendFlagsShowFunc() From: Tatsuo Ishii In-Reply-To: <20251208.182318.1485206482066038076.ishii@postgresql.org> References: <20251208.182318.1485206482066038076.ishii@postgresql.org> X-Mailer: Mew version 6.8 on Emacs 29.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2409:11:4120:300:60bd:dbaa:488:1e49 (failed) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > Currently BackendFlagsShowFunc() and pool_flag_to_str() use almost > identical codes. To avoid the duplication, I would like to propose to > let BackendFlagsShowFunc() to call pool_flag_to_str(). Patch attached. Patch pushed. Thanks. -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp