Date: Thu, 05 Mar 2026 13:16:02 +0900 (JST)
Message-Id: <20260305.131602.968371260826527447.ishii@postgresql.org>
To: yishaitamir@live.com
Cc: pgpool-hackers@lists.postgresql.org
Subject: Re: [PATCH] Downgrade elog(LOG) to elog(DEBUG1) for pi->node_ids
 in get_pools()
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: 
 <SV0P279MB0514A33CA35ECDDA515E7F82C37CA@SV0P279MB0514.NORP279.PROD.OUTLOOK.COM>
References: 
 <SV0P279MB0514A33CA35ECDDA515E7F82C37CA@SV0P279MB0514.NORP279.PROD.OUTLOOK.COM>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20260305.131602.968371260826527447.ishii%40postgresql.org>
Precedence: bulk

> Hi,
> 
>   The attached patch downgrades an elog(LOG) to elog(DEBUG1) in get_pools()
>   (src/utils/pool_process_reporting.c).
> 
>   The elog statement was added in commit 706ca859c as part of the
>   pgpool_adm_pcp_proc_info feature. It prints pi->node_ids bitmap values
>   at LOG level for every connection on every backend whenever pool status
>   is queried.
> 
>   In containerized deployments where a metrics exporter (pgpool2_exporter)
>   continuously polls "show pool_pools", this produces thousands of log
>   lines per minute. We confirmed the fix eliminates the spam on our
>   staging cluster under real production-like traffic.
> 
>   Since the message is purely diagnostic, DEBUG1 is the appropriate level.
> 
>   GitHub issue: https://github.com/pgpool/pgpool2/issues/153

Thanks for the patch. I have already pushed a very similar patch
created by me.
https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commit;h=f647c4a372ea2c2cfae80e4e60f209e236fe41ec

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp