Date: Mon, 09 Mar 2026 18:20:31 +0900 (JST)
Message-Id: <20260309.182031.585673783467995854.ishii@postgresql.org>
To: pgpool-hackers@lists.postgresql.org
Subject: Re: Close listening socokets before forking
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: <20260302.100028.1346768433787074248.ishii@postgresql.org>
References: <20260302.100028.1346768433787074248.ishii@postgresql.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20260309.182031.585673783467995854.ishii%40postgresql.org>
Precedence: bulk

> Currently when pgpool main process forks sub processes (child process
> - user session process, pcp_main process, health check process,
> streaming replication check process and life check process), they
> inherits pgpool and pcp listening sockets. However some of processes
> do not need those sockets:
> 
> - child process - pcp sockets are unnecessary
> - pcp main process - pgpool sockets are unnecessary
> - health check, streaming replication check and life check process -
>   pgpool and pcp sockets are unnecessary
> 
> It could be potential problem when those process go down. Since they
> may keep the listening sockets for a while, which prevents next pgpool
> starting up from binding those ports.
> 
> Attached patch closes those unnecessary sockets after forking. For
> this purpose new function close_listening_sockets() is introduced.

Pushed down to v4.4 (v4.3 was hard to port the patch).

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp