public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tatsuo Ishii <[email protected]>
To: [email protected]
Subject: Adding volatile qualifer
Date: Wed, 01 Jul 2026 10:11:48 +0900 (JST)
Message-ID: <[email protected]> (raw)

While looking into the Pgpool-II main source code, I noticed that
local pointer array "my_backend_status" is not volatile qualified,
while it should have been.

BACKEND_STATUS *my_backend_status[MAX_NUM_BACKENDS];	/* Backend status buffer */

This array members are initialized:

	for (i = 0; i < MAX_NUM_BACKENDS; i++)
	{
		my_backend_status[i] = &(BACKEND_INFO(i).backend_status);
	}

Without volatile, *(my_backend_status[i]) could read state value
because of compiler optimization. Since my_backend_status[i] is
referred to in popular VALID_BACKEND macro, we should fix it in all
supported branches.

Attached is the patch for master branch.

Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp


Attachments:

  [text/x-patch] failover_fix.patch (1.0K, ../[email protected]/2-failover_fix.patch)
  download | inline diff:
diff --git a/src/include/pool.h b/src/include/pool.h
index 549aed30f..ef0876c84 100644
--- a/src/include/pool.h
+++ b/src/include/pool.h
@@ -345,7 +345,7 @@ extern int	pool_get_major_version(void);
 extern bool pool_is_node_to_be_sent_in_current_query(int node_id);
 extern int	pool_virtual_main_db_node_id(void);
 
-extern BACKEND_STATUS *my_backend_status[];
+extern volatile BACKEND_STATUS *my_backend_status[];
 extern int	my_main_node_id;
 
 #define VALID_BACKEND(backend_id) \
diff --git a/src/main/pgpool_main.c b/src/main/pgpool_main.c
index 19d89cb79..ab8946228 100644
--- a/src/main/pgpool_main.c
+++ b/src/main/pgpool_main.c
@@ -277,7 +277,9 @@ static pid_t pgpool_logger_pid = 0; /* pid for pgpool_logger process */
 static pid_t wd_lifecheck_pid = 0;	/* pid for child process handling watchdog
 									 * lifecheck */
 
-BACKEND_STATUS *my_backend_status[MAX_NUM_BACKENDS];	/* Backend status buffer */
+/* Backend status buffer */
+volatile BACKEND_STATUS *my_backend_status[MAX_NUM_BACKENDS];
+
 int			my_main_node_id;	/* Main node id buffer */
 
 /*

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Adding volatile qualifer
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox