Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgpool-hackers-owner+archive@lists.postgresql.org>)
	id 1wfXRU-005VK9-2t
	for pgpool-hackers@arkaria.postgresql.org;
	Fri, 03 Jul 2026 06:32:04 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgpool-hackers-owner+archive@lists.postgresql.org>)
	id 1wfXRT-005sCD-2n
	for pgpool-hackers@arkaria.postgresql.org;
	Fri, 03 Jul 2026 06:32:03 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ishii@postgresql.org>)
	id 1wfXRT-005sC6-2H
	for pgpool-hackers@lists.postgresql.org;
	Fri, 03 Jul 2026 06:32:03 +0000
Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <ishii@postgresql.org>)
	id 1wfXRQ-00000001Qs8-2Lr4
	for pgpool-hackers@lists.postgresql.org;
	Fri, 03 Jul 2026 06:32:03 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=postgresql.org; s=20171124; h=Content-Transfer-Encoding:Content-Type:
	Mime-Version:References:In-Reply-To:From:Subject:Cc:To:Message-Id:Date:Sender
	:Reply-To:Content-ID:Content-Description;
	bh=9xKvco0iG6lqyb4e6f0EdrkTPGiA+16rZWsSbi4q9VU=; b=3xAe85aXXwd5Igpikt1wlChAxU
	kLgNhZ6bZdhVDnz0dQjM2PoCYHQSNIHK6Wef284h8A6nELVdXBj2zMuj0QkyNiEz9SH8vv4FLfSu8
	5VLe/U8qQfl3OIVl4IFsFj0mBT9v6d8Yu+hZQMjED9ejEmO8uWHctFup8a/8hOGvuUFOrRxFsucHS
	4eskXbB733ijb1auZdg87CgRZy+8FXVV1Y9xtq2jDkUWa7ru86/UPjgcsgKpwcrg6HTwiwNGRUspx
	kbCBKY90YdZrD+1/tXf+id4CpTNk2k+vSpsYJnJj7hGp9UVGAfExhogQWsWDpuuBGPUkDecomZZ7w
	j5wsWsoQ==;
Received: from [2409:11:4120:300:2aaf:f5ce:ca8d:8fbc] (helo=localhost)
	by meldrar.postgresql.org with esmtpsa  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ishii@postgresql.org>)
	id 1wfXRN-009Kfi-27;
	Fri, 03 Jul 2026 06:31:59 +0000
Date: Fri, 03 Jul 2026 15:31:48 +0900 (JST)
Message-Id: <20260703.153148.1945583407283747711.ishii@postgresql.org>
To: emond.papegaaij@gmail.com
Cc: pgpool-hackers@lists.postgresql.org
Subject: Re: [PATCH] Segfault in pool_do_auth() when failover races with a
 new connection
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: 
 <CAGXsc+YzD3khY8QAF+LFgX4SQ9U2wei9-JumeMzD1M0=WxrbFA@mail.gmail.com>
References: 
 <CAGXsc+aizSg6Z22=pV8NsFb-FukzT2XP1YriOkOJjOBLVdN-vg@mail.gmail.com>
	<20260702.224517.1668373716426906512.ishii@postgresql.org>
	<CAGXsc+YzD3khY8QAF+LFgX4SQ9U2wei9-JumeMzD1M0=WxrbFA@mail.gmail.com>
X-Mailer: Mew version 6.8 on Emacs 29.3
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Host-Lookup-Failed: Reverse DNS lookup failed for
 2409:11:4120:300:2aaf:f5ce:ca8d:8fbc (failed)
List-Id: <pgpool-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgpool-hackers@lists.postgresql.org>
List-Owner: <mailto:pgpool-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgpool-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20260703.153148.1945583407283747711.ishii%40postgresql.org>
Precedence: bulk

Hi Emond,

> Yes, this looks good. There's one small nit: there's some whitespace
> noise in the patch (space before tab) on the line with
> "my_main_node_id = *(volatile int *) &REAL_MAIN_NODE_ID;"

I fixed this and pushed to all supported branches.
https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commit;h=c39c7b40bf7573e8fc1b4772e99c3b371dca10ed

Thank you!
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp