Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vd0Kp-00CuHs-0K for pgpool-hackers@arkaria.postgresql.org; Tue, 06 Jan 2026 06:14:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vd0Jn-006Xp3-35 for pgpool-hackers@arkaria.postgresql.org; Tue, 06 Jan 2026 06:13:24 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vd0Jn-006Xoo-1u for pgpool-hackers@lists.postgresql.org; Tue, 06 Jan 2026 06:13:24 +0000 Received: from mail-ot1-x331.google.com ([2607:f8b0:4864:20::331]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vd0Jl-004Se4-02 for pgpool-hackers@lists.postgresql.org; Tue, 06 Jan 2026 06:13:23 +0000 Received: by mail-ot1-x331.google.com with SMTP id 46e09a7af769-7c75178c05fso296380a34.0 for ; Mon, 05 Jan 2026 22:13:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tailorbrands.com; s=google; t=1767680000; x=1768284800; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=uR1Fo3s4HgpD0Jksan+A4IJoKhqIur9nweyVOknygu4=; b=brF8rPInvhilRIL8Rop7DkHqTINUR7A/mJCLb4Mda5SPG1WAKptyFddcXSuPoUfQIt JR3576PkUMzdEc9WhVfTD6Z8Lo0yTKttZYFGQK1dP68yGuRCIS3OrtASOrGpkBd13XL9 gB1XULaxJdDc2XMDNnL9X8x0J31hXcYJzB0TkKLieG+efWTKhTCcmZKm0SBISBJWAM+K 4TsN5kQj7BFvRoIuis0sXweSIXvIeo+HRrwUcPxWNywNsyQdbVPfo8yWehlTD9CqDs6a Y/YL6mqTD8UytSyMx/Ld9z6RT367/m1klUUmmraiRcmb1GgEjAb8dXDvbnSt2FXnUjuy rOTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767680000; x=1768284800; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uR1Fo3s4HgpD0Jksan+A4IJoKhqIur9nweyVOknygu4=; b=BqJEDvmI5SielqkyIdvnHLXdRAPhz+3t+wUFZLvAZhVJrxyACppn6X9G0tC2PCFaYG MtKO6DCS9sXRnS4oQJtNFcEdNWQCpUx7xiJgke4Uimft3ROh7r5/tGh2vxS31cVcsk6K da9NdaJyK4PbKIDvuJcu+jE3y2g3ZSJ/spxDBTStQnSwSOF05uPA90xuhOBwuPXKi/0c vBlRscnnJpQCFCd+yQq0HUbNI/oNx0AKsZMSDoPaQCrCyAYwbI0t7Gk1xHyVaeIB6VOK RAWpv4ia1jUko3zoL/8tuC7QO6tfv83pwgjPg44RMl8+CEiaI26yfh4Q6m9ZK8PnIw8/ 34Og== X-Gm-Message-State: AOJu0Yz/vOAxt9lLigwnwCcvfaGtP7xG7VO5GM6vEgrMZJkOq8U6PBJV RpZcwQrK+ZHo7DL4eaObJGPPwMjqNxKQh43zVe+OZd6Zeo2nV13fh9wXiqG9g/sUluGSO5Ie15r pzCOYDXUFZtkftTlz7kXzyhKa5mDNPaoNbudaAuVf7IE1Yv240fnI+ds+ig== X-Gm-Gg: AY/fxX74yV8MKdcoOForAp5UAC9fmpahL7RSlY2JFrCY+j1uIYmru8uply9XDJamG5D kQ5dfuI0u3xwJtm7yL6zsIO4dX82yUxZZIQsa/wZky46BelCaBJoyDiG3g11hjUkwMipVj5Zpc1 +as4opkeETKrO0i8csm9Vv9bmSGxTXbct1g29ncx3s741bJFHx3VePAqgpGzXguhcvIMi+e6QHm ItFrhA10LUWfkGhBGHBUfrh/sKxe688kiKlmDc0mSwRywQJNAosjxPQqcTRJxCFo/Z03GJHeXE1 M/cbAptxyD2mOK32l4mqKr6t9lcHl/H1iD9vamV2hfUK1n8y9YoFEvmrTQOs4DgnC1DRy6rJEpi n9cV8lz4hN3kAh38LojT7wW6Pxmw= X-Google-Smtp-Source: AGHT+IGW1MlIdqpqsgCq/goY3E6FiXgx7w+7r6aKiaIxPbzj/gxz8qL64IYXGk/V29BKrY643CpQD6JtS3CEprhpH7w= X-Received: by 2002:a05:6830:440f:b0:7c7:162:e0c7 with SMTP id 46e09a7af769-7ce4663f7eemr1265270a34.6.1767679999601; Mon, 05 Jan 2026 22:13:19 -0800 (PST) MIME-Version: 1.0 References: <20260106.085257.1146983017764501399.ishii@postgresql.org> <20260106.085931.748008649679987578.ishii@postgresql.org> <20260106.134808.2204131019902796784.ishii@postgresql.org> In-Reply-To: <20260106.134808.2204131019902796784.ishii@postgresql.org> From: Nadav Shatz Date: Tue, 6 Jan 2026 08:13:08 +0200 X-Gm-Features: AQt7F2pG-ZqqzNm7yY-3_AD4GwPvA11F4f3XoVnbDeD-8C-_OJ8B3ywlmJ6juZw Message-ID: Subject: Re: Proposal: recent access based routing for primary-replica setups To: Tatsuo Ishii Cc: pgpool-hackers@lists.postgresql.org Content-Type: multipart/alternative; boundary="0000000000007408540647b21216" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000007408540647b21216 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks a lot! Looking for the merge. I=E2=80=99ll start working on the suggestion for the next stage. Hopefully = it=E2=80=99ll be quicker now that I have the dev env better setup Nadav Shatz Tailor Brands | CTO On Tue, Jan 6, 2026 at 6:48=E2=80=AFAM Tatsuo Ishii = wrote: > > Thank you so much for the help with this! And for the suggestions. > > > > Let=E2=80=99s change the document to match then implementation in this = case. > > Should I share an updated patch or will you modify it on merge? > > I will modify it on merge. No swear. > > Best regards, > -- > Tatsuo Ishii > SRA OSS K.K. > English: http://www.sraoss.co.jp/index_en/ > Japanese:http://www.sraoss.co.jp > > > Nadav Shatz > > Tailor Brands | CTO > > > > > > On Tue, Jan 6, 2026 at 1:59=E2=80=AFAM Tatsuo Ishii > wrote: > > > >> And... attached is the Japanese document. For those who are interested= . > >> -- > >> Tatsuo Ishii > >> SRA OSS K.K. > >> English: http://www.sraoss.co.jp/index_en/ > >> Japanese:http://www.sraoss.co.jp > >> > >> >> Thanks for the help! please find attached the latest version with a= ll > >> >> changes and test passing. > >> > > >> > Thanks for updating patch! I confirmed that all test have passed on = my > >> > Ubunu box. Now I am working on Japanese document. While working on > >> > it, I did followings to the English document. (see attached) > >> > > >> > - Reformat it so that each line is not too long. Like PostgreSQL, I > >> > bend each line at most 78 chars. (I know other parts of document d= o > >> > not follow the rule but I do not want to add more lines not > >> > following the rule). > >> > > >> > - Move replication_delay_source_cmd (string) and > >> > replication_delay_source_timeout (integer) at the bottom of > >> > "5.12. Streaming Replication Check" section. We usually add the ne= w > >> > parameters at the bottom of the page if there's no particular > >> > reason. Previously they were in between prefer_lower_delay_standby > >> > and log_standby_delay. > >> > > >> > - Add following to replication_delay_source_cmd. "The line can be > >> > terminated with or without a new line character." This is observed > >> > from the implementation. I believe this matters for those who try = to > >> > implement replication_delay_source_cmd. > >> > > >> > Lastly I have one question. > >> > > >> > replication_delay_source_timeout (integer) > >> > > >> > Specifies the timeout in seconds for the external command > >> > specified by replication_delay_source_cmd. If the command does n= ot > >> > finish within the timeout, Pgpool-II logs an error and continues > >> > using the built-in method. > >> > > >> > It seems this ("continues using the built-in method") is different > >> > from the actual behavior. It seems that after timeout, the external > >> > command is tried and timeout.... Do you want to fix the source code = to > >> > match with the document? Or change (just remove ""continues using th= e > >> > built-in method") the document? I am fine with changing the document= . > >> > > >> > Best regards, > >> > -- > >> > Tatsuo Ishii > >> > SRA OSS K.K. > >> > English: http://www.sraoss.co.jp/index_en/ > >> > Japanese:http://www.sraoss.co.jp > >> > --0000000000007408540647b21216 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks a lot! Looking for the merge.=C2=A0
I=E2=80=99ll start working on the suggestion for the next stage. = Hopefully it=E2=80=99ll be quicker now that I have the dev env better setup= =C2=A0

Nadav Shatz
Tailor Brands=C2=A0| CTO


On Tue, Jan 6, 20= 26 at 6:48=E2=80=AFAM Tatsuo Ishii <ishii@postgresql.org> wrote:
> Than= k you so much for the help with this! And for the suggestions.
>
> Let=E2=80=99s change the document to match then implementation in this= case.
> Should I share an updated patch or will you modify it on merge?

I will modify it on merge. No swear.

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

> Nadav Shatz
> Tailor Brands | CTO
>
>
> On Tue, Jan 6, 2026 at 1:59=E2=80=AFAM Tatsuo Ishii <ishii@postgresql.org> wr= ote:
>
>> And... attached is the Japanese document. For those who are intere= sted.
>> --
>> Tatsuo Ishii
>> SRA OSS K.K.
>> English: http://www.sraoss.co.jp/index_en/
>> Japanese:http://www.sraoss.co.jp
>>
>> >> Thanks for the help! please find attached the latest vers= ion with all
>> >> changes and test passing.
>> >
>> > Thanks for updating patch! I confirmed that all test have pas= sed on my
>> > Ubunu box.=C2=A0 Now I am working on Japanese document. While= working on
>> > it, I did followings to the English document. (see attached)<= br> >> >
>> > - Reformat it so that each line is not too long. Like Postgre= SQL, I
>> >=C2=A0 =C2=A0bend each line at most 78 chars. (I know other pa= rts of document do
>> >=C2=A0 =C2=A0not follow the rule but I do not want to add more= lines not
>> >=C2=A0 =C2=A0following the rule).
>> >
>> > - Move replication_delay_source_cmd (string) and
>> >=C2=A0 =C2=A0replication_delay_source_timeout (integer) at the= bottom of
>> >=C2=A0 =C2=A0"5.12. Streaming Replication Check" sec= tion. We usually add the new
>> >=C2=A0 =C2=A0parameters at the bottom of the page if there'= ;s no particular
>> >=C2=A0 =C2=A0reason. Previously they were in between prefer_lo= wer_delay_standby
>> >=C2=A0 =C2=A0and log_standby_delay.
>> >
>> > - Add following to replication_delay_source_cmd.=C2=A0 "= The line can be
>> >=C2=A0 =C2=A0terminated with or without a new line character.&= quot; This is observed
>> >=C2=A0 =C2=A0from the implementation. I believe this matters f= or those who try to
>> >=C2=A0 =C2=A0implement replication_delay_source_cmd.
>> >
>> > Lastly I have one question.
>> >
>> > replication_delay_source_timeout (integer)
>> >
>> >=C2=A0 =C2=A0 =C2=A0Specifies the timeout in seconds for the e= xternal command
>> >=C2=A0 =C2=A0 =C2=A0specified by replication_delay_source_cmd.= If the command does not
>> >=C2=A0 =C2=A0 =C2=A0finish within the timeout, Pgpool-II logs = an error and continues
>> >=C2=A0 =C2=A0 =C2=A0using the built-in method.
>> >
>> > It seems this ("continues using the built-in method"= ;) is different
>> > from the actual behavior. It seems that after timeout, the ex= ternal
>> > command is tried and timeout.... Do you want to fix the sourc= e code to
>> > match with the document? Or change (just remove ""c= ontinues using the
>> > built-in method") the document? I am fine with changing = the document.
>> >
>> > Best regards,
>> > --
>> > Tatsuo Ishii
>> > SRA OSS K.K.
>> > English: http://www.sraoss.co.jp/index_en/
>> > Japanese:http://www.sraoss.co.jp
>>
--0000000000007408540647b21216--