Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vcy8g-00Ca3D-1O for pgpool-hackers@arkaria.postgresql.org; Tue, 06 Jan 2026 03:53:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vcy8f-0065dN-03 for pgpool-hackers@arkaria.postgresql.org; Tue, 06 Jan 2026 03:53:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vcy8e-0065dF-2S for pgpool-hackers@lists.postgresql.org; Tue, 06 Jan 2026 03:53:45 +0000 Received: from mail-yw1-x112e.google.com ([2607:f8b0:4864:20::112e]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vcy8d-004nb2-02 for pgpool-hackers@lists.postgresql.org; Tue, 06 Jan 2026 03:53:45 +0000 Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-78fc4425b6bso6334647b3.1 for ; Mon, 05 Jan 2026 19:53:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tailorbrands.com; s=google; t=1767671621; x=1768276421; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=R0CgVsO5e3c3Xt8mXLoqHln3wj8a4NCPuBloKVm2YkU=; b=KL50Kbkix3yTQTU6Qc18vAmQz9M9e/DsdS8SJwEM4vQq3BOrnpHZCtmAmOEfI02QpY 5F8tYtjLFhvS2MJsa6XiwqO5wcRbNqX2QqLCrbkSVRthCu3mHwFgZZ30O10CzjBt+Ep8 42yi/v+zHI2kYX2MDzdiN4YdVPKqa6JUWeaMEaBcC7JprpawUu+7KaS91K7u68qpdId4 0b4rbF/1l9XQ55ZUxA4okXmmV3ddfdDExW74GOgc1gTtIDd82biYUKpDbx0mrzSVg1yq zPyC0PWwknAD3zvsU94cSjXLoLx97xAGzSL65LgPoSI/9xVjmIyqNR1WeTDJiK7zViGC glmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767671621; x=1768276421; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R0CgVsO5e3c3Xt8mXLoqHln3wj8a4NCPuBloKVm2YkU=; b=B+dKIHD11Sx/q9odRdBEQE0Mgg3nHqv+SsX/+p00AXR12kXwY8jTFzC8cipYte9dFy Vx3SPSbk9rCMFp4L5NjIe13xmC+skfJWg4TKtrEbF4Erma9P82DoH+NAJlGgnxP45g7A 86+2kwz2LQsDV3jY3OjyY/JoRkyppF7N7mZ1IbXzRfiOUjsqhLeSR/bdBSBOpSikLwCR ko3i1QIPM0FwwyB9dol78FG9mda1E+zeXxgL3LUrn81mMVIuMlQ7QklicsWPWZJSHln+ 53Qo98G9k22IGiphXJnIOi+VvA6A5mHE2hem9MhS17Iyt8+8TqGCxAzv5aCtVsFCLcVg dLJg== X-Gm-Message-State: AOJu0YxuWDEEzUA1/OWtL7QUDv6rioY/dhghsoRHH+u1PYecZLhKw4RH hIRReIj6jrqgJWcfSyVLztKBw67Q51N4mCrtopMWGzuPBv22p5vFDA2m6s4gT5kc6cZa3SaCY70 BZMWM9z3c1EmyBfKJLNteAlfAZCByVp6xmeAENIWHPw== X-Gm-Gg: AY/fxX5/wiK9DNVI+J1BTUrzfZ1Tv6of+NglpLYUAdkUI+iQi03NNd8LNpXnPzFZrSy 6JG78i+dmvvZo9oipB+vNkdV+U+hyNTT93W0pGk/eBnRyBOp5NclTK5Ay8ff3EOfzjxV61dK7pE Ak3HVXOP7PM8SeXfhwKyt6ocSZTgSErFmJYUvA3hRvrqvsql8s8/3ITYQKqNTJNaQIGAdTYjd0S Mn86GqmjHpHAj1uu8OpgN3hePwWVpMGZqz8F7uupGG9sbuYqTbSLDxeLKdq9WQE0HhoXAOG6n50 TLXdEXI1T+oozLlWofWKXXtmnIYXPc5morGEKJF/pgvlIqtS0LzHCSdjJ1W1MS1PxHbNum7NgVn ML9CgiK/FvtoStYf6/qwDXavQh+Py X-Google-Smtp-Source: AGHT+IH4U0AqTxx8J7851UQJbPiukb7odEcX5sC65ujUrnoKdQ3QfeCFHyWdrhEQdRquVJV5+HG1n2tJ13Re2t8Dg5Q= X-Received: by 2002:a53:ea43:0:b0:646:e354:731e with SMTP id 956f58d0204a3-6470c96c941mr1109813d50.83.1767671621045; Mon, 05 Jan 2026 19:53:41 -0800 (PST) MIME-Version: 1.0 References: <20251229.085803.2270812288334644179.ishii@postgresql.org> <20260106.085257.1146983017764501399.ishii@postgresql.org> <20260106.085931.748008649679987578.ishii@postgresql.org> In-Reply-To: <20260106.085931.748008649679987578.ishii@postgresql.org> From: Nadav Shatz Date: Tue, 6 Jan 2026 05:53:29 +0200 X-Gm-Features: AQt7F2rf2cmvv1kNDWglwWO6DviWtom6LHdAXohz_QSJCIqL7CpzPM-NYUJoRVo Message-ID: Subject: Re: Proposal: recent access based routing for primary-replica setups To: Tatsuo Ishii Cc: pgpool-hackers@lists.postgresql.org Content-Type: multipart/alternative; boundary="0000000000000d6c3c0647b01fa1" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000000d6c3c0647b01fa1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you so much for the help with this! And for the suggestions. Let=E2=80=99s change the document to match then implementation in this case= . Should I share an updated patch or will you modify it on merge? Nadav Shatz Tailor Brands | CTO On Tue, Jan 6, 2026 at 1:59=E2=80=AFAM Tatsuo Ishii = wrote: > And... attached is the Japanese document. For those who are interested. > -- > Tatsuo Ishii > SRA OSS K.K. > English: http://www.sraoss.co.jp/index_en/ > Japanese:http://www.sraoss.co.jp > > >> Thanks for the help! please find attached the latest version with all > >> changes and test passing. > > > > Thanks for updating patch! I confirmed that all test have passed on my > > Ubunu box. Now I am working on Japanese document. While working on > > it, I did followings to the English document. (see attached) > > > > - Reformat it so that each line is not too long. Like PostgreSQL, I > > bend each line at most 78 chars. (I know other parts of document do > > not follow the rule but I do not want to add more lines not > > following the rule). > > > > - Move replication_delay_source_cmd (string) and > > replication_delay_source_timeout (integer) at the bottom of > > "5.12. Streaming Replication Check" section. We usually add the new > > parameters at the bottom of the page if there's no particular > > reason. Previously they were in between prefer_lower_delay_standby > > and log_standby_delay. > > > > - Add following to replication_delay_source_cmd. "The line can be > > terminated with or without a new line character." This is observed > > from the implementation. I believe this matters for those who try to > > implement replication_delay_source_cmd. > > > > Lastly I have one question. > > > > replication_delay_source_timeout (integer) > > > > Specifies the timeout in seconds for the external command > > specified by replication_delay_source_cmd. If the command does not > > finish within the timeout, Pgpool-II logs an error and continues > > using the built-in method. > > > > It seems this ("continues using the built-in method") is different > > from the actual behavior. It seems that after timeout, the external > > command is tried and timeout.... Do you want to fix the source code to > > match with the document? Or change (just remove ""continues using the > > built-in method") the document? I am fine with changing the document. > > > > Best regards, > > -- > > Tatsuo Ishii > > SRA OSS K.K. > > English: http://www.sraoss.co.jp/index_en/ > > Japanese:http://www.sraoss.co.jp > --0000000000000d6c3c0647b01fa1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you so much for the help with this! And for the sug= gestions.=C2=A0

Let=E2= =80=99s change the document to match then implementation in this case.=C2= =A0
Should I share an updated patch or will you modi= fy it on merge?

Nadav Shatz
Tailor Brands=C2=A0| CTO


On Tue, = Jan 6, 2026 at 1:59=E2=80=AFAM Tatsuo Ishii <ishii@postgresql.org> wrote:
= And... attached is the Japanese document. For those who are interested.
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

>> Thanks for the help! please find attached the latest version with = all
>> changes and test passing.
>
> Thanks for updating patch! I confirmed that all test have passed on my=
> Ubunu box.=C2=A0 Now I am working on Japanese document. While working = on
> it, I did followings to the English document. (see attached)
>
> - Reformat it so that each line is not too long. Like PostgreSQL, I >=C2=A0 =C2=A0bend each line at most 78 chars. (I know other parts of do= cument do
>=C2=A0 =C2=A0not follow the rule but I do not want to add more lines no= t
>=C2=A0 =C2=A0following the rule).
>
> - Move replication_delay_source_cmd (string) and
>=C2=A0 =C2=A0replication_delay_source_timeout (integer) at the bottom o= f
>=C2=A0 =C2=A0"5.12. Streaming Replication Check" section. We = usually add the new
>=C2=A0 =C2=A0parameters at the bottom of the page if there's no par= ticular
>=C2=A0 =C2=A0reason. Previously they were in between prefer_lower_delay= _standby
>=C2=A0 =C2=A0and log_standby_delay.
>
> - Add following to replication_delay_source_cmd.=C2=A0 "The line = can be
>=C2=A0 =C2=A0terminated with or without a new line character." Thi= s is observed
>=C2=A0 =C2=A0from the implementation. I believe this matters for those = who try to
>=C2=A0 =C2=A0implement replication_delay_source_cmd.
>
> Lastly I have one question.
>
> replication_delay_source_timeout (integer)
>
>=C2=A0 =C2=A0 =C2=A0Specifies the timeout in seconds for the external c= ommand
>=C2=A0 =C2=A0 =C2=A0specified by replication_delay_source_cmd. If the c= ommand does not
>=C2=A0 =C2=A0 =C2=A0finish within the timeout, Pgpool-II logs an error = and continues
>=C2=A0 =C2=A0 =C2=A0using the built-in method.
>
> It seems this ("continues using the built-in method") is dif= ferent
> from the actual behavior. It seems that after timeout, the external > command is tried and timeout.... Do you want to fix the source code to=
> match with the document? Or change (just remove ""continues = using the
> built-in method") the document? I am fine with changing the docum= ent.
>
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS K.K.
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp
--0000000000000d6c3c0647b01fa1--