MIME-Version: 1.0
References: 
 <CAGXsc+Y7OKp93zSqt1WUCh7ABC7kyZqrxJPFA8AC1woB30S8EQ@mail.gmail.com>
 <20260702.163922.30147080599128209.ishii@postgresql.org>
 <CAGXsc+aizSg6Z22=pV8NsFb-FukzT2XP1YriOkOJjOBLVdN-vg@mail.gmail.com>
 <20260702.224517.1668373716426906512.ishii@postgresql.org>
In-Reply-To: <20260702.224517.1668373716426906512.ishii@postgresql.org>
From: Emond Papegaaij <emond.papegaaij@gmail.com>
Date: Thu, 2 Jul 2026 15:54:56 +0200
Message-ID: 
 <CAGXsc+YzD3khY8QAF+LFgX4SQ9U2wei9-JumeMzD1M0=WxrbFA@mail.gmail.com>
Subject: Re: [PATCH] Segfault in pool_do_auth() when failover races with a new
 connection
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: pgpool-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAGXsc%2BYzD3khY8QAF%2BLFgX4SQ9U2wei9-JumeMzD1M0%3DWxrbFA%40mail.gmail.com>
Precedence: bulk

Hi Tatsuo,

Yes, this looks good. There's one small nit: there's some whitespace
noise in the patch (space before tab) on the line with
"my_main_node_id = *(volatile int *) &REAL_MAIN_NODE_ID;"

Best regards,
Emond

Op do 2 jul 2026 om 15:45 schreef Tatsuo Ishii <ishii@postgresql.org>:
>
> Hi Emond,
>
> > The new patch looks fine to me. There's however one thing Claude
> > pointed out. According to it, my_main_node_id,
> > private_backend_status[], and my_backend_status[] are per-process
> > globals (copied on fork), not shared memory. So, making any of those
> > volatile should not make any difference.
>
> You are right. Attached is the v3 patch.
>
> Regards,
> --
> Tatsuo Ishii
> SRA OSS K.K.
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp