Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wCqFu-002MFI-0a for pgpool-hackers@arkaria.postgresql.org; Wed, 15 Apr 2026 02:45:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wCqFs-00ELUQ-0k for pgpool-hackers@arkaria.postgresql.org; Wed, 15 Apr 2026 02:45:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wCqFr-00ELUI-1w for pgpool-hackers@lists.postgresql.org; Wed, 15 Apr 2026 02:45:28 +0000 Received: from mail-japaneastazlp170100000.outbound.protection.outlook.com ([2a01:111:f403:c405::] helo=TY3P286CU002.outbound.protection.outlook.com) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wCqFp-000000014WA-2GV6 for pgpool-hackers@lists.postgresql.org; Wed, 15 Apr 2026 02:45:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Td8Y3GpNOGv/zDbWhdoMssKuXjznDw5WdXUr6ocVOJSxIF4dU422Gz4VfNVujdEAUECKsc45vPbp+hb08mdM2Rr8N8WbI7zV79RBumMCHDFFjg5Lx/wQ/+nkvPsc9WcXK2vRo/RL7pAECqCFcqm7vaR+mYBoxCxpg67TbTjO1TX/Rz1V3GtTxnhLCOuWinU1jiwn/DuXSumkT5rsjm0oBm16UnBtDLCCtsC4LAM9Li63PFOkyckuwwmkMAYAEKOtqUS4aCrN8a8I1FD7lEPunMmlTzahFDLilhu1VcNoljc8tkaafF0136KsdqLnkZ15F8nBXs8Ac+9JwiQYbTspew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SoZnPAk0EDUzcAW2hH9LGiRP1VqK28e5+ZwSYo9RfBU=; b=QbxwwO180lI0bHBurMd9tucAVZk/LpxebdzyPBVASwGKZmA/xK/FAiBdl5nL4hi75UXIYa/PBQgiAT8EzdpSkBjWVvJ9yX3SVBN6sW9nYZQN38euzKo8NL5KvE9j/q+tzvEnJrZfn9XuBEANvIhwwCEKcYwNwTP1pdA2KWSjEFya8M7rWJH6bs8s1c+UcPg/U89bSFoHYhXkD38ShOJ0JrPhGxGl/RGxZU9w+dd5+jnoWXDfHUKpnEIOWH1BTfQXDIDz72KWQhDzDieAgblqWKHNXMuPBeMVAe/mmTW5wykY2ru4rMkZX373D2Qn0agGLkfJ/RxBfzdbQjTpKPbOlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sraoss.co.jp; dmarc=pass action=none header.from=sraoss.co.jp; dkim=pass header.d=sraoss.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sraoss.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SoZnPAk0EDUzcAW2hH9LGiRP1VqK28e5+ZwSYo9RfBU=; b=NiwMKP0FvcQXgJ86dT5f5g0KUapFaF7mZcsfZJhzd4VuovwFpz1MxdKQXOLtAlcc3I6EdIz6YW0u22woGBwDNFgpOcB63IYCUOROC2GnhTm2bsVaaLYzUWNt7OGiloi7mL5xGZXYn4pIlUOdd8F9XCiFFh1XyGSApEI1hV8ipTh3WD3TTblctYQsoaSuolavTOSERnd9/RO5gA/KDWQmgnd2DpR7aZ1+WztDJ1yRcmiQgIUU2gMEMNeALGtXs+nokcmiKruQiEsZYIMTo2dGT0DHUcwd33/CssRAW+uiGY2CIayfi0iFIPUiKHCyhPonG/peZvBrLqZJWOjJEbyFYg== Received: from OS9PR01MB17364.jpnprd01.prod.outlook.com (2603:1096:604:451::5) by TYYPR01MB13484.jpnprd01.prod.outlook.com (2603:1096:405:1c0::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Wed, 15 Apr 2026 02:45:18 +0000 Received: from OS9PR01MB17364.jpnprd01.prod.outlook.com ([fe80::90b8:31f2:568d:e350]) by OS9PR01MB17364.jpnprd01.prod.outlook.com ([fe80::90b8:31f2:568d:e350%3]) with mapi id 15.20.9769.046; Wed, 15 Apr 2026 02:45:18 +0000 From: Koshino Taiki To: Tatsuo Ishii CC: "pgpool-hackers@lists.postgresql.org" Subject: Re: Proposal: Add lifecheck started status to pcp_watchdog_info. Thread-Topic: Proposal: Add lifecheck started status to pcp_watchdog_info. Thread-Index: AQHcvPc5U84OBWZ6b0qE5FuXWU0wDbXfT2KAgAA4kmo= Date: Wed, 15 Apr 2026 02:45:18 +0000 Message-ID: References: <20260415.081601.1744698268968717621.ishii@postgresql.org> In-Reply-To: <20260415.081601.1744698268968717621.ishii@postgresql.org> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=sraoss.co.jp; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: OS9PR01MB17364:EE_|TYYPR01MB13484:EE_ x-ms-office365-filtering-correlation-id: cdbc2afa-d639-4a09-c04f-08de9a9907cb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|366016|376014|8096899003|56012099003|22082099003|18002099003|3613699012|13003099007|38070700021; x-microsoft-antispam-message-info: KRljLltKYw+RIjKgdcCfz3e+KTU6QKpGBRXrWZY+yQ0MYAt+8xUy3+uCEDzCJ1omJJvBdFTZz7bat+E+vUE496CApTZ/Q378y51P8wxngLV/lyn+dAbVBDgueOpXEctlOkwOFWgG4yrq2dEgMIrUaNrqyEq+N3LctUHUhWzNQGbP8hHvhtfOEIaFINuZonXwNky+aVBZWCW/XWIvHxRuXBhLjTH6tU2sml9GdIcmpBW1H97puamY2XXElMYhC4hmNZR59wBY/ToaitS5sYoMs5bUO8mmOpFi3OdwTXUvRlS3mN5K6In2KwA5ziCOKKyPgKL0iRqBqZ1JCbDlnaCo0/NDZ/HG5oaHJRZVKybZQNl3mDjlj+KYCtghYZNgFUK1T0/D7dhqj9Rj966jaDQSnlwnS1vx8rVkxXXOn4Tzg5AOY3xFF8iaS0N6+YBgmSUIa8vB1is3kd8tj7CiL2qLy6S3RqTY51zhQGg7OYTORCol2yz6yR4dWX7224yFMtXuGuK/o8k3OsSXv2DxZjZYUhGenwptScswKqOOqCOkApqUF/eEnz/ZpNRjsKFQ/8TfEXkNx2hqi/HzSeiH9UqEOY8gAm/Ffo89MkXGzlT5V9T0Nat+gOgPyBiZyxEALkBsLui0tkV0Hq56mgds1UI4mdUpeAElVdQsuGKWyR/0DRTp3bHzwM/uiToxYhrI7q40+HqIE5ZZv5+okwxzZQC89GkHu/16d8R2iSaArrwCpm/Y81bHq4GR7RcoMiqU9aq3sdgXNOjOidm4mViRV1dWvw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:ja;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS9PR01MB17364.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(8096899003)(56012099003)(22082099003)(18002099003)(3613699012)(13003099007)(38070700021);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?TTcyR3RTVmgveEI3a0VacVVBclJidEFjZWxZbm1SQnFuSUFmNzJ3MHli?= =?iso-2022-jp?B?YzRFb0JQNDQ1STZOWXlFVDBkN3hCNzhlUXhJRE9xUktEQ1pXQTJDZnl4?= =?iso-2022-jp?B?ajZIMUY1T0ZzTGh4V045SlVUKy9STVB1TDdRbWxHRnJJVkZPWUd4NGV1?= =?iso-2022-jp?B?VGt4NnFXMlh6M1ZkNzdwb0U5VVhheE45ODlEdUYzK09hVytFYnYwWjdD?= =?iso-2022-jp?B?bFE3cGU5QVVWaEF1TGtuVXplRWllV2NHRk5wRTFFMytZSHlsbFFJelVD?= =?iso-2022-jp?B?L05TcWZiR2dRNXpRYWxjMFU1NDMwQUNIKzd0SFNZRm8rdE9DUlJFT1gy?= =?iso-2022-jp?B?SktkaDRuUk5wKy93Q2tiN0F2Qko0cG02TXIvdmtuTDNYYWVicWdGOEk5?= =?iso-2022-jp?B?cWtRdk5HWWpsTHVHa0s1Vmpnb1dQbWV2amEzeHJrcFoyRmZCSE1NaXVo?= =?iso-2022-jp?B?UHpvWklOazNtY3ZMYWpObkNJa1pkV3NhVDFqdlF4N0MwMS85Z1FhRVVC?= =?iso-2022-jp?B?T2dVZWl6dnBHb2dqN3pPVWRvSTZ2c3VEcmdFTUpTMzQxM0FaK3MxRFVP?= =?iso-2022-jp?B?S2ZDclVJeVhLUkNaSVhSV0hjbW5IMEk4eXFURVB1ZU5uZXV5TGZHNloy?= =?iso-2022-jp?B?ZmhEWjhJNHRvbTBpWUtXUzVnamtGM1Fqa3NQMmppYmt2VkJVaGE5MTRX?= =?iso-2022-jp?B?UGJ6ZG9ZZnltdHNvdFBtUDhzcHVYZmRLNGQ0SmZscFdES04vdHlVdkJh?= =?iso-2022-jp?B?UDVGV2RFMmFlKzd4V0lLSVpDRU40ekdRMWFRd0YrYi8xQW5DenRjdVE1?= =?iso-2022-jp?B?VE05dnBxN0l6c3hPREtuNDB0YlJmdjRjRVh4TjNwSnlQRVBYSXR0Sldm?= =?iso-2022-jp?B?VnlBTHFkT0U4T0lpYmdDWlV4TGwyL2tpMXFwUTNUU2M4bzlJWitFZUlT?= =?iso-2022-jp?B?ekRjQ3pSZ3RCQ1VXT25qc0NpczhOckFHaXo5aUFReXYxNitDRWlPNUhU?= =?iso-2022-jp?B?UTFQU0FpUWgzNWRPa2hHM1d5VkVNaHpad2RpdW9nZHFYT0JIN2NodHp4?= =?iso-2022-jp?B?Zy9SQlZ3YUkvaXEwY3ZaUktaTm15REl5STNTbE83TU10SkVOZlBEcThE?= =?iso-2022-jp?B?Y21GTHlQdXgzL2phZ3UvN21uN0NxVXFIdDNnOWJ3S3BnVVc2aGlDaHZT?= =?iso-2022-jp?B?VXBUYVlodTRMZGd4cndsTjlCellLazlwSTNFYWFCd0VXNkRNb3NMVnlP?= =?iso-2022-jp?B?WlFGWVl2SXpFNlU1T1kxSVhBZ2RRTkhTSHEvaGJGdldiblltZXVYcm5h?= =?iso-2022-jp?B?azdZZkpGL1MvSjJ3RHN6cmR5Tmh5cFpBU1hJTGJadGxrdU1NeHVtMnZC?= =?iso-2022-jp?B?UWpMK1pJMk4vdTdVcUUxaElkR250RWo4K1dXdmtZSGhQa0NMcU9qbHRB?= =?iso-2022-jp?B?ZkkxZkxJNzF2QjhJN3FWVGMrYThXQWhmUzM4ckxQNHJFUE5kc0pKUENM?= =?iso-2022-jp?B?cm9FMmdRaFhNZXl5d3JqT2piS1dRRUxiNnUwV2tvSHZsYmloelhFdWtR?= =?iso-2022-jp?B?UmtDMFFPNTBaK2hnR2tMSUc3cjdMMHAxUjRIcElKNVlqM3ppU2l2SThj?= =?iso-2022-jp?B?VS8zTnZPWjc0SkRSWWk3NVIwYWUrU0FGWTVNaFBVNE12Sks4NDlWc2NO?= =?iso-2022-jp?B?dXhuOGIyVlFaUVVudmswcjBTdUxPNmdPeGF1SjBuaHlaeXJWQ01SbnRu?= =?iso-2022-jp?B?OEZpYjNwZE16L1RMZnpSTVNSdStqL2lPbFRPdXhpbGNaK2VqWm5zWnFn?= =?iso-2022-jp?B?RUVkVWdFYm42MFNFVkJXRTZWYTZ5T090ZzVNekkwbkNRZm1WbEx5aVly?= =?iso-2022-jp?B?cDlRTEJXM0lSckpDamZyVkMvZHpLclF1NjZmdHAyK2g3SExkVlpjTmNR?= =?iso-2022-jp?B?Q1A4R1g2dzR6V3NmRnljRHFFWS94VTFLSVViZzM5c2FGT08waVcvb1Z2?= =?iso-2022-jp?B?dFZxZituSnBCT01OdkNSKzAzQU1hYnMwZVdHMkJIeSszTTQ1U1MwZUJj?= =?iso-2022-jp?B?QVcraUtWdm5Rdi9sRjhyMTEvUEV3aGk0MDFNRHF5ZFNHY2xlb1Btdm1Q?= =?iso-2022-jp?B?TW4rSUZOV2dTeCtkQ2toYUlURlRXVWpLbUZ3emwxYnMzUU96RHBhTDZ1?= =?iso-2022-jp?B?M0dMYmN0cFNGUzlqNllEOFFqczZEVkIzVk9JUWNVbEhtTFFmdWs5ckF0?= =?iso-2022-jp?B?bUIvK0ZNekZpUXpieDczVzFyTlBkNXBnS0ZYSnBGczJBT1MwWnhvanEw?= =?iso-2022-jp?B?SEpUZU9ZdkFEL2U5TjNZcEZHNUJqbUt5VmdUY3gxdkx2eUxIMXIzUjhB?= =?iso-2022-jp?B?UzJ5Yis0L1laYS85S0kwcndPZmVIQkRYTWR0OUFPZmdKbklzdXNlOGhy?= =?iso-2022-jp?B?MjVmU1N5dVJJNW1uOUpnR3BGemdXdnNRRU9rWk1vZUlGamFlMzRyTkZl?= =?iso-2022-jp?B?R1NBdkRF?= Content-Type: multipart/alternative; boundary="_000_OS9PR01MB17364604EE50807847ABB328394222OS9PR01MB17364jp_" MIME-Version: 1.0 X-OriginatorOrg: sraoss.co.jp X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: OS9PR01MB17364.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdbc2afa-d639-4a09-c04f-08de9a9907cb X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2026 02:45:18.4289 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 75db6c32-352e-4063-ae79-cafb8623f6db X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ag+jQ98mXPfIehZ0gc+k+mx1B850AiUgXsqeE+Lu6t812vJkqkyQ4WMrwxqsnXnYjhkfXGatgaHg5+9qSLw1zw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYYPR01MB13484 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --_000_OS9PR01MB17364604EE50807847ABB328394222OS9PR01MB17364jp_ Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Hi, Thank you for your review. I have made the changes based on your review. The final commit has been pushed to the master branch: https://git.postgresql.org/gitweb/?p=3Dpgpool2.git;a=3Dcommitdiff;h=3D366e6= 02bca9ecc70f91fb52afcad74facbcec215 Best regards, Taiki Koshino SRA OSS K.K. TEL: 03-5979-2701 FAX: 03-5979-2702 URL: https://www.sraoss.co.jp/ ________________________________ =1B$B:9=3DP?M=1B(B: Tatsuo Ishii =1B$BAw?.=1B(B: 2026 =1B$BG/=1B(B 4 =1B$B7n=1B(B 15 =1B$BF|=1B(B (=1B$B?eMK= F|=1B(B) 8:16 =1B$B08@h=1B(B: Koshino Taiki Cc: pgpool-hackers@lists.postgresql.org =1B$B7oL>=1B(B: Re: Proposal: Add lifecheck started status to pcp_watchdog_= info. Thank you for the patch! > Hi, > This patch adds a new field, "Lifecheck Started", to the pcp_watchdog_inf= o output. > Currently, users need to inspect logs to verify whether the lifecheck has= started on each node. > This change allows the status to be checked directly from a single comman= d, making it easier to verify behavior and perform regression testing. > For example: > > $ pcp_watchdog_info -h localhost -p 9898 -U pgpool -v > Password: > Watchdog Cluster Information > Total Nodes : 3 > Remote Nodes : 2 > Member Remote Nodes : 2 > Alive Remote Nodes : 2 > Nodes required for quorum: 2 > Quorum state : QUORUM EXIST > Local node escalation : YES > Leader Node Name : server1:9999 Linux server1.localdomain > Leader Host Name : server1 > > Watchdog Node Information > Node Name : server1:9999 Linux server1.localdomain > Host Name : server1 > Delegate IP : 192.168.56.150 > Pgpool port : 9999 > Watchdog port : 9000 > Node priority : 1 > Status : 4 > Status Name : LEADER > Membership Status : MEMBER > Lifecheck Started : YES This will make admin's lifer easier. So I took a look at the patch. > From f353f922222f70fad1d104f76adca1010578d40a Mon Sep 17 00:00:00 2001 > From: Taiki Koshino > Date: Thu, 26 Mar 2026 17:04:37 +0900 > Subject: [PATCH v9] Add Lifecheck Started status to pcp_watchdog_info out= put. > > This commit enhances the pcp_watchdog_info command by adding a new field,= Lifecheck Started, > which indicates whether lifecheck has been started on each watchdog node = (NO: not started, YES: started). > > This allows users to check the lifecheck status directly from the command= output without inspecting logs. > > Add a lifecheck_started member to WatchdogNode. When the lifecheck proces= s > detects that lifecheck has started, it notifies the watchdog process, whi= ch > sets lifecheck_started to true. When set to true, the status is propagate= d > across the cluster. > > Add a lifecheck_status field to pcp_watchdog_info so that the latest > lifecheck_started status is displayed when the command is called. Commit message itself looks good except some lines are too long. It would be better to fold lines so that they are no longer 78 chars or so. diff --git a/src/include/pcp/pcp.h b/src/include/pcp/pcp.h index e40b96bdc..15a4abb01 100644 --- a/src/include/pcp/pcp.h +++ b/src/include/pcp/pcp.h @@ -48,6 +48,8 @@ typedef struct PCPWDNodeInfo int wd_priority; /* node priority in leader= election */ int pgpool_port; /* pgpool port */ char delegate_ip[WD_MAX_HOST_NAMELEN]; /* delegat= e IP */ + bool lifecheck_started; /* True means lifecheck is start= ed, + * f= alse means lifecheck is not started */ The comment for lifecheck_started is a little bit redundant. What about something like /* True if lifecheck has started */"? Rest of the patch looks good to me. Regards, -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp --_000_OS9PR01MB17364604EE50807847ABB328394222OS9PR01MB17364jp_ Content-Type: text/html; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable
Hi,
Thank you for your review.
I have made the changes based on your review.
The final commit has been pushed to the master branch:
https://git.postgresql.org/gitweb= /?p=3Dpgpool2.git;a=3Dcommitdiff;h=3D366e602bca9ecc70f91fb52afcad74facbcec2= 15
Best regards,

Taiki Koshino<koshino@sraoss.co.jp>
SRA OSS K.K.
TEL: 03-5979-2701 FAX: 03-5979-2702
URL: https://www= .sraoss.co.jp/



=1B$B:9=3DP?M=1B(B: Tatsuo Ishii <ishii@postgresql.org> =1B$BAw?.=1B(B: 2026 =1B$BG/=1B(B 4 =1B$B7n=1B(B 15 =1B$BF|=1B(= B (=1B$B?eMKF|=1B(B) 8:16
=1B$B08@h=1B(B: Koshino Taiki <koshino@sraoss.co.jp>
Cc: pgpool-hackers@lists.postgresql.org <pgpool-hackers@list= s.postgresql.org>
=1B$B7oL>=1B(B: Re: Proposal: Add lifecheck started status to p= cp_watchdog_info.

Thank you for the patch!

> Hi,
> This patch adds a new field, "Lifecheck Started", to the pcp= _watchdog_info output.
> Currently, users need to inspect logs to verify whether the lifecheck = has started on each node.
> This change allows the status to be checked directly from a single com= mand, making it easier to verify behavior and perform regression testing. > For example:
>
> $ pcp_watchdog_info -h localhost -p 9898 -U pgpool -v
> Password:
> Watchdog Cluster Information
> Total Nodes          = ;    : 3
> Remote Nodes         &nbs= p;   : 2
> Member Remote Nodes      : 2
> Alive Remote Nodes       : 2
> Nodes required for quorum: 2
> Quorum state         &nbs= p;   : QUORUM EXIST
> Local node escalation    : YES
> Leader Node Name         : ser= ver1:9999 Linux server1.localdomain
> Leader Host Name         : ser= ver1
>
> Watchdog Node Information
> Node Name         : server1:99= 99 Linux server1.localdomain
> Host Name         : server1 > Delegate IP       : 192.168.56.150
> Pgpool port       : 9999
> Watchdog port     : 9000
> Node priority     : 1
> Status          &nbs= p; : 4
> Status Name       : LEADER
> Membership Status : MEMBER
> Lifecheck Started : YES

This will make admin's lifer easier.
So I took a look at the patch.

> From f353f922222f70fad1d104f76adca1010578d40a Mon Sep 17 00:00:00 2001=
> From: Taiki Koshino <koshino@sraoss.co.jp>
> Date: Thu, 26 Mar 2026 17:04:37 +0900
> Subject: [PATCH v9] Add Lifecheck Started status to pcp_watchdog_info = output.
>
> This commit enhances the pcp_watchdog_info command by adding a new fie= ld, Lifecheck Started,
> which indicates whether lifecheck has been started on each watchdog no= de (NO: not started, YES: started).
>
> This allows users to check the lifecheck status directly from the comm= and output without inspecting logs.
>
> Add a lifecheck_started member to WatchdogNode. When the lifecheck pro= cess
> detects that lifecheck has started, it notifies the watchdog process, = which
> sets lifecheck_started to true. When set to true, the status is propag= ated
> across the cluster.
>
> Add a lifecheck_status field to pcp_watchdog_info so that the latest > lifecheck_started status is displayed when the command is called.

Commit message itself looks good except some lines are too long. It
would be better to fold lines so that they are no longer 78 chars or
so.

diff --git a/src/include/pcp/pcp.h b/src/include/pcp/pcp.h
index e40b96bdc..15a4abb01 100644
--- a/src/include/pcp/pcp.h
+++ b/src/include/pcp/pcp.h
@@ -48,6 +48,8 @@ typedef struct PCPWDNodeInfo
         int    = ;            &n= bsp;    wd_priority;    /* node priority in l= eader election */
         int    = ;            &n= bsp;    pgpool_port;    /* pgpool port */
         char   &nbs= p;        delegate_ip[WD_MAX_HOST_NAMELE= N];       /* delegate IP */
+       bool     &nb= sp;      lifecheck_started; /* True means lifechec= k is started,
+            &n= bsp;            = ;            &n= bsp;            = ;            &n= bsp;        * false means lifecheck is n= ot started */

The comment for lifecheck_started is a little bit redundant. What
about something like /* True if lifecheck has started */"?

Rest of the patch looks good to me.

Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
--_000_OS9PR01MB17364604EE50807847ABB328394222OS9PR01MB17364jp_--