X-Original-To: pgsql-admin-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [64.117.225.181]) by svr1.postgresql.org (Postfix) with ESMTP id 054A6CC406; Tue, 15 Jul 2003 19:50:00 +0000 (GMT) Received: from svr1.postgresql.org ([64.117.224.193]) by localhost (svr5.postgresql.org [64.117.225.181]) (amavisd-new, port 10024) with ESMTP id 33046-01; Tue, 15 Jul 2003 19:50:16 +0000 (GMT) Received: from mailav.tor1.inquent.com (mail.inquent.com [216.208.117.106]) by svr1.postgresql.org (Postfix) with ESMTP id 81C42CC48E; Tue, 15 Jul 2003 16:49:48 -0300 (ADT) Received: from localhost (localhost [127.0.0.1]) by mailav.tor1.inquent.com (Postfix) with ESMTP id 569BF10258; Tue, 15 Jul 2003 15:43:25 -0400 (EDT) Received: from [10.0.2.7] (unknown [10.0.2.7]) by mailav.tor1.inquent.com (Postfix) with ESMTP id 15BD11024D; Tue, 15 Jul 2003 15:43:23 -0400 (EDT) Subject: Re: problems with pg_restore From: Rod Taylor To: Tom Lane Cc: "Kuhn, Dylan K (4520500D)" , pgsql-admin@postgresql.org, PostgreSQL Development In-Reply-To: <23211.1058286389@sss.pgh.pa.us> References: <78ED1F30F0D85B4698FBD6CF2A5AC8F5A576F9@NAWECHLKEX01VA.nadsuswe.nads.navy.mil> <23211.1058286389@sss.pgh.pa.us> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-FtbH+8YWkVQ//RA39VP+" Message-Id: <1058298650.9981.117.camel@jester> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.3 Date: 15 Jul 2003 19:50:51 +0000 X-Virus-Scanned: by AMaViS perl-11 X-Virus-Scanned: by amavisd-new at postgresql.org X-Archive-Number: 200307/182 X-Sequence-Number: 9522 --=-FtbH+8YWkVQ//RA39VP+ Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > Hm. Evidently not :-(. The COMMENT ON DATABASE facility is a bit bogus > anyway (since there's no way to make the comments visible across > databases). You might be best advised not to use it. >=20 > Hackers: this seems like an extremely bad side-effect of what we thought > was a simple addition of a helpful check. I am thinking we should > either remove the check again, or downgrade it to a WARNING (though I'm > not quite sure how to phrase the warning ...). Any thoughts? How about going the other way and removing the requirement to explicitly state the database? COMMENT ON DATABASE IS 'This comment is on the current database.'; --=-FtbH+8YWkVQ//RA39VP+ Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (FreeBSD) iD8DBQA/FFsa6DETLow6vwwRAr4dAJ9NEqifqWv1tDRq49xWlFGNZni/xQCcD4cu JbQ7mxQatlZTkdVI0xL7nrA= =Jqlk -----END PGP SIGNATURE----- --=-FtbH+8YWkVQ//RA39VP+--