X-Original-To: pgsql-admin-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 6B872D1B1DC for ; Tue, 29 Jun 2004 17:39:17 -0300 (ADT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 04020-05 for ; Tue, 29 Jun 2004 20:39:10 +0000 (GMT) Received: from cmailm1.svr.pol.co.uk (cmailm1.svr.pol.co.uk [195.92.193.18]) by svr1.postgresql.org (Postfix) with ESMTP id 8032BD1B27C for ; Tue, 29 Jun 2004 17:39:07 -0300 (ADT) Received: from modem-3803.lemur.dialup.pol.co.uk ([217.135.142.219] helo=[192.168.0.100]) by cmailm1.svr.pol.co.uk with esmtp (Exim 4.14) id 1BfPNk-0002o1-CF for pgsql-admin@postgresql.org; Tue, 29 Jun 2004 21:39:08 +0100 Subject: PITR Error Message assistance From: Simon Riggs To: pgsql-admin@postgresql.org In-Reply-To: <200406291036.48477.josh@agliodbs.com> References: <200406291036.48477.josh@agliodbs.com> Content-Type: text/plain Organization: 2nd Quadrant Message-Id: <1088541547.3266.7534.camel@stromboli> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 (1.4.5-7) Date: Tue, 29 Jun 2004 21:39:07 +0100 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.1 tagged_above=0.0 required=5.0 tests=RCVD_IN_SORBS X-Spam-Level: X-Archive-Number: 200406/377 X-Sequence-Number: 14037 Could I ask for feedback on the error messages used with the archiver and restore functionality? Possibly those of you with a hand in the Error Message style guide? The messages need the eye of some administrators to suggest some better phrases. Some probably need some explanation, but I'll leave that for you to decide which...and what you think it should say instead. Thinking that if they need explanation, they probably are worded wrongly... These are copied straight from recent patch: + elog(WARNING, "could not set notify for archiver to read log file %u, segment %u", + ereport(LOG, + (errmsg("recovery.conf found...starting archive recovery"))); + elog(LOG, "redo: restored \"%s\" from archive", restoreXlog); + elog(LOG, "rename failed %s %s",recoveryXlog, lastrecoXlog); + elog(LOG, "redo: cannot restore \"%s\" from archive", restoreXlog); + ereport(ERROR, + (errcode_for_file_access(), + errmsg("could not write archive_status file \"%s\" ", + tmppath))); + elog(LOG, "redo: moving last restored xlog to %s", tmppath); + elog(LOG, "redo: rename failed"); + elog(LOG, "redo: archive chain ends; using local copy of \"%s\"", restoreXlog); + (errmsg("archive recovery complete"))); + ereport(LOG, ! (errmsg("too many transaction log files, removing \"%s\"", xlde->d_name))); + ereport(WARNING, + (errcode_for_file_access(), + errmsg("chkpt: cannot find archive_status file: %s ", + rlogpath))); + elog(WARNING, "chkpt: archiving not yet started for log file %s", + xlog); DEBUG MESSAGES + elog(LOG, "backend: written %s", rlogpath ); + + elog(LOG, "postmaster: WAKEN_ARCHIVER received, sending SIGUSR1 to archiver"); + elog(LOG, "chkpt: archiving done for log file %s", + xlog); + elog(LOG, "redo: system(%s)", xlogRestoreCmd); Thanks, Best regards, Simon Riggs