Subject: Re: [HACKERS] Point in Time Recovery
From: Simon Riggs <simon@2ndquadrant.com>
To: Mark Kirkwood <markir@coretech.co.nz>
Cc: markw@osdl.org, pgman@candle.pha.pa.us, kn@mgnet.de,
	tgl@sss.pgh.pa.us, pgsql-hackers@postgresql.org, pgsql-admin@postgresql.org
In-Reply-To: <40F5E14A.4090003@coretech.co.nz>
References: <200407141555.i6EFtnk22984@mail.osdl.org>
	<1089833620.17493.4624.camel@stromboli>
	<40F5E14A.4090003@coretech.co.nz>
Content-Type: text/plain
Organization: 2nd Quadrant
Message-Id: <1089875702.17493.5539.camel@stromboli>
Mime-Version: 1.0
Date: Thu, 15 Jul 2004 08:15:03 +0100
Content-Transfer-Encoding: 7bit

On Thu, 2004-07-15 at 02:43, Mark Kirkwood wrote:
> I noticed that compiling with 5_1 patch applied fails due to 
> XLOG_archive_dir being removed from xlog.c , but 
> src/backend/commands/tablecmds.c still uses it.
> 
> I did the following to tablecmds.c :
> 
> 5408c5408
> <               extern char XLOG_archive_dir[];
> ---
>  >               extern char *XLogArchiveDest;
> 5410c5410
> <               use_wal = XLOG_archive_dir[0] && !rel->rd_istemp;
> ---
>  >               use_wal = XLogArchiveDest[0] && !rel->rd_istemp;
> 
> 

Yes, I discovered that myself.

The fix is included in pitr_v5_2.patch...

Your patch follows the right thinking and looks like it would have
worked...
- XLogArchiveMode carries the main bool value for mode on/off
- XLogArchiveDest might also be used, though best to use the mode

Thanks for looking through the code...

Best Regards, Simon Riggs