Subject: Re: [HACKERS] Point in Time Recovery
From: Simon Riggs <simon@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Bruce Momjian <pgman@candle.pha.pa.us>,
	pgsql-patches@postgresql.org
In-Reply-To: <8192.1090206830@sss.pgh.pa.us>
References: <200407172015.i6HKFLK17349@candle.pha.pa.us>
	<25995.1090127083@sss.pgh.pa.us>
	<1090182052.17493.18904.camel@stromboli>
	<8192.1090206830@sss.pgh.pa.us>
Content-Type: text/plain
Organization: 2nd Quadrant
Message-Id: <1090219142.17493.22023.camel@stromboli>
Mime-Version: 1.0
Date: Mon, 19 Jul 2004 07:39:03 +0100
Content-Transfer-Encoding: 7bit

On Mon, 2004-07-19 at 04:13, Tom Lane wrote:
> Simon Riggs <simon@2ndquadrant.com> writes:
> > When archiver starts the FIRST thing it does is run a test to confirm
> > that the command string works, so setting archive_command to '' would
> > simply generate an error.
> 
> No, it would do no such thing; the test cannot really tell anything more
> than whether system("foo") returns zero ... and at least on my machine,
> system("") returns zero.  It certainly does not prove that any data went
> to anyplace safe.
> 
> I diked that test out of the committed patch because I felt it cluttered
> the archive area without actually proving anything of interest.  We can
> revisit the point if you like.
> 

If the test doesn't guarantee success, then it needs to go....

Thanks for removing it.

Best Regards, Simon Riggs