X-Original-To: pgsql-hackers-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 894E9D1B388 for ; Tue, 20 Jul 2004 11:24:16 -0300 (ADT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 28738-05 for ; Tue, 20 Jul 2004 14:24:19 +0000 (GMT) Received: from cmailg1.svr.pol.co.uk (cmailg1.svr.pol.co.uk [195.92.195.171]) by svr1.postgresql.org (Postfix) with ESMTP id 3E48CD1B387 for ; Tue, 20 Jul 2004 11:24:14 -0300 (ADT) Received: from modem-457.llama.dialup.pol.co.uk ([217.135.177.201] helo=[192.168.0.100]) by cmailg1.svr.pol.co.uk with esmtp (Exim 4.14) id 1BmvXU-0000d1-Hs; Tue, 20 Jul 2004 15:24:16 +0100 Subject: Re: PITR COPY Failure (was Point in Time Recovery) From: Simon Riggs To: Tom Lane Cc: Mark Kirkwood , pgsql-hackers@postgresql.org In-Reply-To: <13342.1090332035@sss.pgh.pa.us> References: <200407141555.i6EFtnk22984@mail.osdl.org> <1089833620.17493.4624.camel@stromboli> <40F5E14A.4090003@coretech.co.nz> <1089875702.17493.5539.camel@stromboli> <40F652C6.4070007@coretech.co.nz> <1089935215.17493.6906.camel@stromboli> <40FA0F93.8010607@coretech.co.nz> <40FC6BF2.5050701@coretech.co.nz> <3607.1090296869@sss.pgh.pa.us> <1090324635.28049.2554.camel@stromboli> <7787.1090327914@sss.pgh.pa.us> <1090329086.28049.2708.camel@stromboli> <13342.1090332035@sss.pgh.pa.us> Content-Type: text/plain Organization: 2nd Quadrant Message-Id: <1090333455.28049.2917.camel@stromboli> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 (1.4.5-7) Date: Tue, 20 Jul 2004 15:24:16 +0100 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.1 tagged_above=0.0 required=5.0 tests=RCVD_IN_SORBS X-Spam-Level: X-Archive-Number: 200407/1030 X-Sequence-Number: 56591 On Tue, 2004-07-20 at 15:00, Tom Lane wrote: > Simon Riggs writes: > > On Tue, 2004-07-20 at 13:51, Tom Lane wrote: > >> Ugh. I'm beginning to think we ought to revert the patch that added the > >> don't-split-across-files logic to XLogInsert; that seems to have broken > >> more assumptions than I realized. > > > The problem was that a zero length XLOG_WASTED_SPACE record just fell > > out of ReadRecord when it shouldn't have. By giving it a helping hand it > > makes it through with pointers correctly set, and everything else was > > already thought of in the earlier patch, so xlog_redo etc happens. > > Yeah, but the WASTED_SPACE/FILE_HEADER stuff is already pretty ugly, and > adding two more warts to the code to support it is sticking in my craw. > I'm thinking it would be cleaner to treat the extra labeling information > as an extension of the WAL page header. Sounds like a better solution than scrabbling around at the end of file with too many edge cases to test properly ...over to you then... Best Regards, Simon Riggs