Subject: Re: [HACKERS] Point in Time Recovery
From: Simon Riggs <simon@2ndquadrant.com>
To: Klaus Naumann <kn@mgnet.de>
Cc: markw@osdl.org, tgl@sss.pgh.pa.us, pgman@candle.pha.pa.us,
	pgsql-patches@postgresql.org
In-Reply-To: <Pine.LNX.4.58.0407201825340.930@spock.intra.net>
References: <200407201536.i6KFa7122392@mail.osdl.org>
	<Pine.LNX.4.58.0407201825340.930@spock.intra.net>
Content-Type: text/plain
Organization: 2nd Quadrant
Message-Id: <1090344478.3377.8.camel@stromboli>
Mime-Version: 1.0
Date: Tue, 20 Jul 2004 18:27:58 +0100
Content-Transfer-Encoding: 7bit

On Tue, 2004-07-20 at 17:29, Klaus Naumann wrote:
> On Tue, 20 Jul 2004 markw@osdl.org wrote:
> 
> > FATAL:  unrecognized configuration parameter "archive_mode"
> >
> > Have I missed something since it has been committed?
> 
> Yes, Tom has removed this option in favorite of just setting
> archive_command to a value which then enables the PITR code also.
> 
> But as I've seen this isn't discussed to the very end currently.
> 
> My 2ct: I'd prefer to have archive_mode in the config as it really makes
> clear that this database is archiving. I fear users will not understand
> that giving a program for archival will also enable the PITR function.
> 

I do also think that option should go back in, just to be explicit.

A more important omission is the deletion of a message to indicate that
the server is acting in archive_mode....so there's no visual clue in the
log to warn an admin that its been turned off now or incorrectly
specified (by somebody else, of course). (At least using the default log
mode).

Best Regards, Simon Riggs