Subject: Re: [HACKERS] Point in Time Recovery
From: Simon Riggs <simon@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Klaus Naumann <kn@mgnet.de>, markw@osdl.org,
	pgman@candle.pha.pa.us, pgsql-patches@postgresql.org
In-Reply-To: <8659.1090421629@sss.pgh.pa.us>
References: <200407201536.i6KFa7122392@mail.osdl.org>
	<Pine.LNX.4.58.0407201825340.930@spock.intra.net>
	<1090344478.3377.8.camel@stromboli> <4589.1090388994@sss.pgh.pa.us>
	<Pine.LNX.4.58.0407210946170.930@spock.intra.net>
	<8659.1090421629@sss.pgh.pa.us>
Content-Type: text/plain
Organization: 2nd Quadrant
Message-Id: <1090439667.2658.1260.camel@localhost.localdomain>
Mime-Version: 1.0
Date: Wed, 21 Jul 2004 21:00:49 +0100
Content-Transfer-Encoding: 7bit

On Wed, 2004-07-21 at 15:53, Tom Lane wrote:
> Klaus Naumann <kn@mgnet.de> writes:
> > Simon doesn't mean the recovery part. Instead he means the "normal"
> > startup of the server. It has to be absolutely clear (in the logfile!) if
> > the server was started in archive mode or not. Otherwise you always have
> > to guess.
> 
> Why would you guess?  "SHOW archive_command" will tell you, without
> question, at any time.  I don't see the point of placing such a message
> in the postmaster log --- in normal circumstances the postmaster will
> still be running long after its starting messages have been discarded
> due to log rotation.
> 
> Also, the current implementation allows you to stop and start archiving
> on-the-fly, so a start-time message would be an unreliable guide to what
> the postmaster is actually doing at the moment.
> 

Overall, this is a small point and I think we should leave Tom alone, to
focus on the bigger issues that we care about.

Tom has done an amazingly good job in the last few days of refactoring
some reasonably ugly code on my part, all without a murmur. I relent on
this to allow everything to be finished in time. 

The PITR journey has just begun, so there will be further opportunity to
discuss and agree what constitutes real issues and then correct them.
This may not be on that list later.

Best Regards, Simon Riggs