Received: from localhost (maia-1.hub.org [200.46.204.191]) by postgresql.org (Postfix) with ESMTP id A6BA39FA040 for ; Fri, 8 Dec 2006 12:17:00 -0400 (AST) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.191]) (amavisd-new, port 10024) with ESMTP id 29454-01 for ; Fri, 8 Dec 2006 12:16:52 -0400 (AST) X-Greylist: from auto-whitelisted by SQLgrey-1.7.4 Received: from lists.commandprompt.com (host-130.commandprompt.net [207.173.203.130]) by postgresql.org (Postfix) with ESMTP id ACF879F9F75 for ; Fri, 8 Dec 2006 12:16:51 -0400 (AST) Received: from [192.168.1.95] (or-67-76-146-141.sta.embarqhsd.net [67.76.146.141]) (authenticated bits=0) by lists.commandprompt.com (8.13.7/8.13.6) with ESMTP id kB8GGpLw014205 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Fri, 8 Dec 2006 08:16:52 -0800 Subject: Re: tsearch2 problem rank_cd() (possibly) crashing postgres From: "Joshua D. Drake" To: Tom Lane Cc: pgsql-admin@postgresql.org, Oleg Bartunov , Teodor Sigaev In-Reply-To: <5964.1165594374@sss.pgh.pa.us> References: <5485.1165592831@sss.pgh.pa.us> <1165593203.12459.81.camel@localhost.localdomain> <5964.1165594374@sss.pgh.pa.us> Content-Type: text/plain Organization: Command Prompt, Inc. Date: Fri, 08 Dec 2006 08:18:42 -0800 Message-Id: <1165594722.24745.4.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 0.88.5, clamav-milter version 0.88.5 on projects.commandprompt.com X-Virus-Status: Clean X-Greylist: Sender succeded SMTP AUTH authentication, not delayed by milter-greylist-1.6 (lists.commandprompt.com [192.168.2.159]); Fri, 08 Dec 2006 08:16:52 -0800 (PST) X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200612/83 X-Sequence-Number: 23875 On Fri, 2006-12-08 at 11:12 -0500, Tom Lane wrote: > "Joshua D. Drake" writes: > > On Fri, 2006-12-08 at 10:47 -0500, Tom Lane wrote: > >> Nonetheless, dumping core on bad input is not acceptable behavior ... > > > Is it time to require test cases for contrib modules? > > tsearch2 *has* a regression test. ATM it sounds like the problem is > that the OP tried to use a new library with old pg_proc entries that > defined different parameter sets for the same-named C functions; a > situation that no regression test would have exercised anyway. Hmmmm, is there a way that we could have library version requirements for all C based functions? So if within PGLIB version 3 was present but the function was calling version 2... It would politely fail with a mismatched version warning? Sincerely, Joshua D. Drake -- === The PostgreSQL Company: Command Prompt, Inc. === Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240 Providing the most comprehensive PostgreSQL solutions since 1997 http://www.commandprompt.com/ Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate