Received: from localhost (maia-4.hub.org [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 365099FB94B for ; Mon, 2 Jul 2007 06:40:01 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 52882-09 for ; Mon, 2 Jul 2007 06:39:58 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.5 Received: from mail01.enterprisedb.com (mail01.enterprisedb.com [63.246.7.168]) by postgresql.org (Postfix) with ESMTP id 07FEC9FB948 for ; Mon, 2 Jul 2007 06:39:57 -0300 (ADT) thread-index: Ace8jPyAZ924jx6OTfKGkaRf2zlrzg== Received: from [172.24.32.50] ([62.232.55.118]) by mail01.enterprisedb.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 2 Jul 2007 05:40:11 -0400 Content-Class: urn:content-classes:message Subject: Re: missing history file Importance: normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.3790.4073 From: "Simon Riggs" To: "Tom Lane" Cc: "George Wilk" , In-Reply-To: <12838.1183128750@sss.pgh.pa.us> References: <008401c7ba44$5efa4170$0d7ba8c0@ellacoya.com> <1183124513.3589.104.camel@silverbirch.site> <12838.1183128750@sss.pgh.pa.us> Content-Type: text/plain; charset="iso-8859-1" Date: Mon, 02 Jul 2007 10:35:56 +0100 Message-ID: <1183368957.3589.160.camel@silverbirch.site> MIME-Version: 1.0 X-Mailer: Evolution 2.6.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 02 Jul 2007 09:40:11.0953 (UTC) FILETIME=[FC68FA10:01C7BC8C] X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200707/3 X-Sequence-Number: 25984 On Fri, 2007-06-29 at 10:52 -0400, Tom Lane wrote: > "Simon Riggs" writes: > > Just ignore 00000001. Recovery will work fine even if absent. Don't > > ignore all history files though, just that one. Hmmm, come to think of > > it, why is it requesting it at all? We should just skip that request. > > No, because then people would misdesign their recovery scripts to not > be able to deal with not finding a history file. As things are, they > will certainly be exposed to that case in any testing they do. If we > optimize this call away, then they won't see the case until they're in > very deep doo-doo. Main reason for suggesting this is that there is already code to optimize the call away in one place, but not in another, which seems strange either way. -- Simon Riggs EnterpriseDB http://www.enterprisedb.com