Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 4035C2E3E66 for ; Wed, 16 Jan 2008 13:13:45 -0400 (AST) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 82294-01-2 for ; Wed, 16 Jan 2008 13:13:37 -0400 (AST) Received: from defout.telus.net (defout.telus.net [199.185.220.240]) by postgresql.org (Postfix) with ESMTP id A08DC2E3BE3 for ; Wed, 16 Jan 2008 13:13:24 -0400 (AST) Received: from localhost ([199.185.220.240]) by priv-edtnes23.telusplanet.net (InterMail vM.7.08.03.00 201-2186-126-20070710) with ESMTP id <20080116171258.GPOL10210.priv-edtnes23.telusplanet.net@localhost>; Wed, 16 Jan 2008 10:12:58 -0700 Received: from 209.17.179.1 ( [209.17.179.1]) as user a3a18850@192.168.200.1 by webmail.telus.net with HTTP; Wed, 16 Jan 2008 09:13:23 -0800 Message-ID: <1200503603.478e3b33346ca@webmail.telus.net> Date: Wed, 16 Jan 2008 09:13:23 -0800 From: Mischa Sandberg To: Tom Lane Cc: pgsql-hackers@postgresql.org Subject: Re: postgresql in FreeBSD jails: proposal References: <1200501702.478e33c61b74e@webmail.telus.net> <25135.1200503395@sss.pgh.pa.us> In-Reply-To: <25135.1200503395@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit User-Agent: Internet Messaging Program (IMP) 3.1-cvs X-Originating-IP: 209.17.179.1 X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200801/661 X-Sequence-Number: 112935 Quoting Tom Lane : > Mischa Sandberg writes: > > + /* In a FreeBSD jail, you can't "kill -0" a > postmaster > > + * running in a different jail, so the shm seg > might > > + * still be in use. Safer to test nattch ? > > + */ > > + if (kill(1,0) && errno == ESRCH && > PGSharedMemoryIsInUse(0,NextShmemSegID)) > > + continue; > > Isn't the last part of that test backward? If it isn't, I don't > understand what it's for at all. Serious blush here. Yes.