Received: from localhost (maia-2.hub.org [200.46.204.187]) by postgresql.org (Postfix) with ESMTP id DEEEF9F9D1A; Wed, 29 Aug 2007 20:05:42 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.187]) (amavisd-maia, port 10024) with ESMTP id 16826-07-2; Wed, 29 Aug 2007 20:05:26 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.5 X-Greylist: from auto-whitelisted by SQLgrey-1.7.5 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by postgresql.org (Postfix) with ESMTP id 765499F9B03; Wed, 29 Aug 2007 20:05:28 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.1/8.14.1) with ESMTP id l7TN5QOk012578; Wed, 29 Aug 2007 19:05:26 -0400 (EDT) To: Alvaro Herrera cc: dx k9 , pgsql-admin@postgresql.org, pgsql-hackers@postgresql.org Subject: Re: reindexdb hangs In-reply-to: <20070829222341.GX7911@alvh.no-ip.org> References: <22018.1178144703@sss.pgh.pa.us> <20070825222150.GU31461@alvh.no-ip.org> <4909.1188082313@sss.pgh.pa.us> <20070829222341.GX7911@alvh.no-ip.org> Comments: In-reply-to Alvaro Herrera message dated "Wed, 29 Aug 2007 18:23:41 -0400" Date: Wed, 29 Aug 2007 19:05:26 -0400 Message-ID: <12577.1188428726@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200708/408 X-Sequence-Number: 26739 Alvaro Herrera writes: > Tom Lane wrote: >> Yeah, an extra fetch of the pg_class row doesn't seem all that nice. >> I think you'd want to check it in approximately the same two places >> where pg_class_ownercheck() is applied (one for the 1-xact and one for >> the multi-xact path). > Actually, the 1-xact path does not need it, because the check is already > elsewhere. Yeah, but if you do it there it's one added comparison (isOtherTempNamespace is very cheap, and you can get the namespace cheaply from the already-open rel). This way you need an extra syscache lookup because you are insisting on doing the check in a place where you don't have easy access to the pg_class row. Doesn't seem better. regards, tom lane