X-Original-To: pgsql-hackers-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id C4383D1B243 for ; Fri, 16 Jul 2004 00:49:26 -0300 (ADT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 16295-05 for ; Fri, 16 Jul 2004 03:49:24 +0000 (GMT) Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by svr1.postgresql.org (Postfix) with ESMTP id 81B49D1B241 for ; Fri, 16 Jul 2004 00:49:23 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.12.11/8.12.11) with ESMTP id i6G3n5vw015403; Thu, 15 Jul 2004 23:49:05 -0400 (EDT) To: Simon Riggs Cc: Alvaro Herrera , HISADAMasaki , pgsql-hackers@postgresql.org Subject: Re: Point in Time Recovery In-reply-to: <1089935513.17493.6923.camel@stromboli> References: <200407132242.i6DMgg612564@candle.pha.pa.us> <1089760416.17493.3327.camel@stromboli> <20040715210816.E8A3.HISADA.MASAKI@lab.ntt.co.jp> <1089931442.17493.6749.camel@stromboli> <20040715230133.GB8005@dcc.uchile.cl> <1089935513.17493.6923.camel@stromboli> Comments: In-reply-to Simon Riggs message dated "Fri, 16 Jul 2004 00:51:53 +0100" Date: Thu, 15 Jul 2004 23:49:04 -0400 Message-ID: <15402.1089949744@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.0 tagged_above=0.0 required=5.0 tests= X-Spam-Level: X-Archive-Number: 200407/843 X-Sequence-Number: 56404 Simon Riggs writes: > On Fri, 2004-07-16 at 00:01, Alvaro Herrera wrote: >> My manpage for signal(2) says that you shouldn't assign SIG_IGN to >> SIGCHLD, according to POSIX. > So - I should be setting this to SIG_DFL and thats good for everyone? Yeah, we learned the same lesson in the backend not too many releases back. SIG_IGN'ing SIGCHLD is bad voodoo; it'll work on some platforms but not others. You could do worse than to look at the existing handling of signals in the postmaster and its children; that code has been beat on pretty heavily ... regards, tom lane