pg.ddx.io  pgsql-admin@postgresql.org mailing list archive  
help / color / mirror / Atom feed
dbmirror modifies pg_proc nextval/setval functions
3+ messages / 2 participants
[nested] [flat]

* dbmirror modifies pg_proc nextval/setval functions
@ 2005-06-01 02:48 James Doherty <JDoherty@yak.ca>
  0 siblings, 0 replies; 3+ messages in thread

From: James Doherty @ 2005-06-01 02:48 UTC (permalink / raw)
  To: pgsql-admin

Hi all,

I'm trying out dbmirror  for postgres 8.0.3 and I ran into some problems that I traced back to the setup sql script the MirrorSetup.sql, the standard nextval and setval get renamed using the following:

UPDATE pg_proc SET proname='nextval_pg' WHERE proname='nextval';

UPDATE pg_proc set proname='setval_pg' WHERE proname='setval';

The library file pending.c refers to it as nextval_pg as well.

This changing of the name of what I would think is a pretty basic function seems pretty risky. It fried a couple of my tables that were using serials and I had to go back and alter them to use the new name. I know it's in the contrib and not fully supported but still...

I'm still pretty new to postgres, so I'm thinking I'm missing something.

James

^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* dbmirror modifies pg_proc nextval/setval functions
@ 2005-06-01 16:30 James Doherty <JDoherty@yak.ca>
  2005-06-01 17:19 ` Re: dbmirror modifies pg_proc nextval/setval functions Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 3+ messages in thread

From: James Doherty @ 2005-06-01 16:30 UTC (permalink / raw)
  To: pgsql-admin

Hi all,

I'm trying out dbmirror  for postgres 8.0.3 and I ran into some problems that I traced back to the setup sql script, MirrorSetup.sql, the standard nextval and setval get renamed using the following:

UPDATE pg_proc SET proname='nextval_pg' WHERE proname='nextval';

UPDATE pg_proc set proname='setval_pg' WHERE proname='setval';

The library file pending.c refers to it as nextval_pg as well.

This changing of the name of what I would think is a pretty basic function seems pretty risky. It fried a couple of my tables that were using serials and I had to go back and alter them to use the new name. I know it's in the contrib and not fully supported but still...

I'm still pretty new to postgres, so I'm thinking I'm missing something. I emailed the maintainer of dbmirror at the email in the README but it bounced as user does not exist.

James

^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: dbmirror modifies pg_proc nextval/setval functions
  2005-06-01 16:30 dbmirror modifies pg_proc nextval/setval functions James Doherty <JDoherty@yak.ca>
@ 2005-06-01 17:19 ` Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 3+ messages in thread

From: Tom Lane @ 2005-06-01 17:19 UTC (permalink / raw)
  To: James Doherty <JDoherty@yak.ca>; +Cc: pgsql-admin

"James Doherty" <JDoherty@yak.ca> writes:
> This changing of the name of what I would think is a pretty basic
> function seems pretty risky.

My, that *is* ugly isn't it?  Not to mention that the replacement setval
functions are created with the wrong argument datatypes.  This looks
exceedingly broken to me.

			regards, tom lane



^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2005-06-01 17:19 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2005-06-01 02:48 dbmirror modifies pg_proc nextval/setval functions James Doherty <JDoherty@yak.ca>
2005-06-01 16:30 dbmirror modifies pg_proc nextval/setval functions James Doherty <JDoherty@yak.ca>
2005-06-01 17:19 ` Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox