Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M272780=pgsql-hackers-arkari@postgresql.org>)
 id 1YqniE-0003DN-9K
 for pgsql-hackers@arkaria.postgresql.org; Fri, 08 May 2015 19:13:30 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M272780=pgsql-hackers-arkari@postgresql.org>)
 id 1YqniD-00024d-PU
 for pgsql-hackers@arkaria.postgresql.org; Fri, 08 May 2015 19:13:29 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
 by malur.postgresql.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA256:256)
 (Exim 4.80) (envelope-from <tgl@sss.pgh.pa.us>) id 1YqniC-00024X-SF
 for pgsql-hackers@postgresql.org; Fri, 08 May 2015 19:13:29 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
 by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
 (Exim 4.84) (envelope-from <tgl@sss.pgh.pa.us>) id 1YqniA-00049n-J6
 for pgsql-hackers@postgresql.org; Fri, 08 May 2015 19:13:27 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
 by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id t48JD49P018912;
 Fri, 8 May 2015 15:13:04 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@heroku.com>, Andres Freund <andres@anarazel.de>
cc: Heikki Linnakangas <hlinnaka@iki.fi>, Jeff Janes <jeff.janes@gmail.com>,
 Stephen Frost <sfrost@snowman.net>,
 Dean Rasheed <dean.a.rasheed@gmail.com>, Bruce Momjian <bruce@momjian.us>,
 Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0
In-reply-to: <18691.1431112058@sss.pgh.pa.us>
References: 
 <CAM3SWZTGE0z5_E8wRi9wt3qgOiMpSwtwr5uDcZDGhRZ1_pz6vg@mail.gmail.com>
 <20150508150340.GJ12950@alap3.anarazel.de> <9096.1431102730@sss.pgh.pa.us>
 <20150508165246.GO12950@alap3.anarazel.de> <10633.1431105922@sss.pgh.pa.us>
 <554CF44B.3080808@iki.fi> <20150508180636.GR12950@alap3.anarazel.de>
 <CAM3SWZQsh=uDmyRW4NzYqU_kv8qAsvCYpJuuYSuikfuJbLANQQ@mail.gmail.com>
 <20150508181445.GS12950@alap3.anarazel.de> <17473.1431109846@sss.pgh.pa.us>
 <20150508183504.GU12950@alap3.anarazel.de> <18313.1431111562@sss.pgh.pa.us>
 <CAM3SWZSqDaRG9c12XewsKqFLkNAak1kxie3UZ6+Wi9cC2UKT8g@mail.gmail.com>
 <18691.1431112058@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
 message dated "Fri, 08 May 2015 15:07:38 -0400"
Date: Fri, 08 May 2015 15:13:04 -0400
Message-ID: <18911.1431112384@sss.pgh.pa.us>
X-Pg-Spam-Score: -0.4 (/)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

I wrote:
> Peter Geoghegan <pg@heroku.com> writes:
>> On Fri, May 8, 2015 at 11:59 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Ooops.  But shouldn't that have failed 100% of the time in a CCA build?
>>> Or is the candidates list fairly noncritical?

>> The candidates list is absolutely critical.

> Oh, I was confusing CCA with RELCACHE_FORCE_RELEASE, which does something
> a bit different.

Actually, looking closer, the quoted code is simply not broken without
RELCACHE_FORCE_RELEASE: without that, neither heap_close nor index_close
will do anything that could cause a cache flush.  So while it's certainly
good pratice to move that lappend_oid call up, it does not explain the
observed symptoms.  We still need some more investigation here.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers