X-Original-To: pgsql-admin-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [64.117.224.192]) by svr1.postgresql.org (Postfix) with ESMTP id D6EBCCC493; Tue, 15 Jul 2003 20:46:46 +0000 (GMT) Received: from svr1.postgresql.org ([64.117.224.193]) by localhost (svr4.postgresql.org [64.117.224.192]) (amavisd-new, port 10024) with ESMTP id 01786-06; Tue, 15 Jul 2003 20:47:12 +0000 (GMT) Received: from cm-lcon2-53-101.cm.vtr.net (CM-lcon2-53-101.cm.vtr.net [200.83.53.101]) by svr1.postgresql.org (Postfix) with ESMTP id 5A6A9CC406; Tue, 15 Jul 2003 17:46:44 -0300 (ADT) Received: by cm-lcon2-53-101.cm.vtr.net (Postfix, from userid 500) id 7C5AC80081; Tue, 15 Jul 2003 16:47:04 -0400 (CLT) Date: Tue, 15 Jul 2003 16:47:04 -0400 From: Alvaro Herrera To: Tom Lane Cc: Rod Taylor , "Kuhn, Dylan K (4520500D)" , pgsql-admin@postgresql.org, PostgreSQL Development Subject: Re: [HACKERS] problems with pg_restore Message-ID: <20030715204704.GC9410@dcc.uchile.cl> References: <78ED1F30F0D85B4698FBD6CF2A5AC8F5A576F9@NAWECHLKEX01VA.nadsuswe.nads.navy.mil> <23211.1058286389@sss.pgh.pa.us> <1058298650.9981.117.camel@jester> <8299.1058299393@sss.pgh.pa.us> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8299.1058299393@sss.pgh.pa.us> User-Agent: Mutt/1.4i X-Virus-Scanned: by amavisd-new at postgresql.org X-Archive-Number: 200307/184 X-Sequence-Number: 9524 On Tue, Jul 15, 2003 at 04:03:13PM -0400, Tom Lane wrote: > Given the current implementation, it seems like there are three possible > behaviors for COMMENT ON DATABASE when the database name isn't the same > as the current database: There's a fourth possibility: ignore the command and issue a WARNING. Restores the database in both cases (in same database and in a different one), and sets the correct comment only if the database name is correct, giving a hint that the comment should be manually set. -- Alvaro Herrera () "I can't go to a restaurant and order food because I keep looking at the fonts on the menu. Five minutes later I realize that it's also talking about food" (Donald Knuth)