Date: Thu, 15 Jul 2004 21:16:58 +0900
From: HISADAMasaki <hisada.masaki@lab.ntt.co.jp>
To: Simon Riggs <simon@2ndquadrant.com>
Subject: Re: Point in Time Recovery
Cc: pgsql-hackers@postgresql.org
In-Reply-To: <1089760416.17493.3327.camel@stromboli>
References: <200407132242.i6DMgg612564@candle.pha.pa.us>
	<1089760416.17493.3327.camel@stromboli>
Message-Id: <20040715210816.E8A3.HISADA.MASAKI@lab.ntt.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit

Dear Simon,

I've just tested pitr_v5_2.patch and got an error message
during archiving process as follows.

-- begin
 LOG:  archive command="cp /usr/local/pgsql/data/pg_xlog/0000000000000000 /tmp",return code=-1
-- end

The command called in system(3) works, but it returns -1.
system(3) can not get right exit code from its child process,
when SIGCHLD is set as SIG_IGN.

So I did following change to pgarch_Main() in pgarch.c

-- line 236 ---
- pgsignal(SIGCHLD, SIG_IGN);

-- line 236 ---
+ pgsignal(SIGCHLD, SIG_DFL);

After that, 
the error message doen't come out and it seems to be working propery.

Regards,
Hisada, Masaki

On Wed, 14 Jul 2004 00:13:37 +0100
Simon Riggs <simon@2ndquadrant.com> wrote:

> PITR Patch v5_1 just posted has Point in Time Recovery working....
> 
> Still some rough edges....but we really need some testers now to give
> this a try and let me know what you think.
> 
> Klaus Naumann and Mark Wong are the only [non-committers] to have tried
> to run the code (and let me know about it), so please have a look at
> [PATCHES] and try it out.
> 
> Many thanks,
> 
> Simon Riggs
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend

-- 
HISADA, Masaki <hisada.masaki@lab.ntt.co.jp>