X-Original-To: pgsql-patches-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 7E2E4D1B178 for ; Sat, 17 Jul 2004 17:15:31 -0300 (ADT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 57859-08 for ; Sat, 17 Jul 2004 20:15:29 +0000 (GMT) Received: from candle.pha.pa.us (candle.pha.pa.us [207.106.42.251]) by svr1.postgresql.org (Postfix) with ESMTP id 95975D1B386 for ; Sat, 17 Jul 2004 17:15:23 -0300 (ADT) Received: (from pgman@localhost) by candle.pha.pa.us (8.11.6/8.11.6) id i6HKFLK17349; Sat, 17 Jul 2004 16:15:21 -0400 (EDT) From: Bruce Momjian Message-Id: <200407172015.i6HKFLK17349@candle.pha.pa.us> Subject: Re: [HACKERS] Point in Time Recovery In-Reply-To: <16190.1090091906@sss.pgh.pa.us> To: Tom Lane Date: Sat, 17 Jul 2004 16:15:21 -0400 (EDT) Cc: Simon Riggs , pgsql-patches@postgresql.org X-Mailer: ELM [version 2.4ME+ PL108 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.0 tagged_above=0.0 required=5.0 tests= X-Spam-Level: X-Archive-Number: 200407/288 X-Sequence-Number: 11958 Tom Lane wrote: > Bruce Momjian writes: > > Tom Lane wrote: > >> What is the point of having both archive_program and archive_dest as > >> GUC variables? > > > I assume archive_dest is used for both archive and recovery of archives. > > You assume wrong; it's not used there. There isn't any real good > reason to suppose that the recovery process is going to fetch the files > from exactly where archiving put them, anyhow. > > > I think the idea is that you would turn archiving on and off regularly > > Why in the world would you do that? People who want PITR at all will > want it 24x7. > > > while you might never change the archive_command value. Also, how would > > you disable it? Set it to "", and if you do, you then have not way to > > remember your command string when you want to re-enable it. > > Leave the original value in a comment, if you're going to want it again > later. > > I don't think any of the above arguments outweigh the risk of people > shooting themselves in the foot by enabling archive_mode without > specifying a proper command/destination. So you want to merge them all into a single command string. That does seem less error-prone. I see a few variables that turn off when set to '' like unix_socket_*. How would this command string work? How do you specify the WAL file name to transfer? -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073