From: Bruce Momjian <pgman@candle.pha.pa.us>
Message-Id: <200407281621.i6SGLlD28030@candle.pha.pa.us>
Subject: Re: [HACKERS] Point in Time Recovery
In-Reply-To: <1090439667.2658.1260.camel@localhost.localdomain>
To: Simon Riggs <simon@2ndquadrant.com>
Date: Wed, 28 Jul 2004 12:21:47 -0400 (EDT)
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Klaus Naumann <kn@mgnet.de>,
	markw@osdl.org, pgsql-patches@postgresql.org
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII


I do think we need a boolean for start/stop of archiving, rather than
setting it to '' to turn it off.  Tom, I think the group agreed to this
on clarity grounds.  I would like the server to throw an error if you
try to turn on archiving and the command is set to ''.

---------------------------------------------------------------------------

Simon Riggs wrote:
> On Wed, 2004-07-21 at 15:53, Tom Lane wrote:
> > Klaus Naumann <kn@mgnet.de> writes:
> > > Simon doesn't mean the recovery part. Instead he means the "normal"
> > > startup of the server. It has to be absolutely clear (in the logfile!) if
> > > the server was started in archive mode or not. Otherwise you always have
> > > to guess.
> > 
> > Why would you guess?  "SHOW archive_command" will tell you, without
> > question, at any time.  I don't see the point of placing such a message
> > in the postmaster log --- in normal circumstances the postmaster will
> > still be running long after its starting messages have been discarded
> > due to log rotation.
> > 
> > Also, the current implementation allows you to stop and start archiving
> > on-the-fly, so a start-time message would be an unreliable guide to what
> > the postmaster is actually doing at the moment.
> > 
> 
> Overall, this is a small point and I think we should leave Tom alone, to
> focus on the bigger issues that we care about.
> 
> Tom has done an amazingly good job in the last few days of refactoring
> some reasonably ugly code on my part, all without a murmur. I relent on
> this to allow everything to be finished in time. 
> 
> The PITR journey has just begun, so there will be further opportunity to
> discuss and agree what constitutes real issues and then correct them.
> This may not be on that list later.
> 
> Best Regards, Simon Riggs
> 
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073