From: Bruce Momjian <pgman@candle.pha.pa.us>
Message-Id: <200407291707.i6TH7pK15909@candle.pha.pa.us>
Subject: Re: [HACKERS] Point in Time Recovery
In-Reply-To: <200407281621.i6SGLlD28030@candle.pha.pa.us>
To: Bruce Momjian <pgman@candle.pha.pa.us>
Date: Thu, 29 Jul 2004 13:07:51 -0400 (EDT)
Cc: Simon Riggs <simon@2ndquadrant.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Klaus Naumann <kn@mgnet.de>,
	markw@osdl.org, pgsql-patches@postgresql.org
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII

Bruce Momjian wrote:
> 
> I do think we need a boolean for start/stop of archiving, rather than
> setting it to '' to turn it off.  Tom, I think the group agreed to this
> on clarity grounds.  I would like the server to throw an error if you
> try to turn on archiving and the command is set to ''.

Let me illustrate.  To turn off archiving you have to change:

	#archive_command = ''
	archive_command = 'cp %p /mnt/server/archivedir/%f'

to
	
	archive_command = ''
	#archive_command = 'cp %p /mnt/server/archivedir/%f'

and if you comment both or neither, you have problems.

With a boolean it would be:

	archive_mode = on
	archive_command = 'cp %p /mnt/server/archivedir/%f'

	archive_mode = off
	archive_command = 'cp %p /mnt/server/archivedir/%f'

Now, if you say people will rarely turn archiving on/off, then one
parameter seems to make more sense.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073