X-Original-To: pgsql-patches-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 10E5352934 for ; Mon, 30 May 2005 16:37:59 -0300 (ADT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 40112-02 for ; Mon, 30 May 2005 19:37:57 +0000 (GMT) Received: from candle.pha.pa.us (candle.pha.pa.us [64.139.89.126]) by svr1.postgresql.org (Postfix) with ESMTP id 1A7A552862 for ; Mon, 30 May 2005 16:37:56 -0300 (ADT) Received: (from pgman@localhost) by candle.pha.pa.us (8.11.6/8.11.6) id j4UJc3218101; Mon, 30 May 2005 15:38:03 -0400 (EDT) From: Bruce Momjian Message-Id: <200505301938.j4UJc3218101@candle.pha.pa.us> Subject: Re: [ADMIN] Config option log_statement In-Reply-To: <20050514230045.6150.qmail@web51009.mail.yahoo.com> To: S Murthy Kambhampaty Date: Mon, 30 May 2005 15:38:03 -0400 (EDT) Cc: PostgreSQL-patches X-Mailer: ELM [version 2.4ME+ PL121 (25)] MIME-Version: 1.0 Content-Type: multipart/mixed; boundary=ELM1117481883-4136-3_ Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.01 tagged_above=0 required=5 tests=AWL X-Spam-Level: X-Archive-Number: 200505/380 X-Sequence-Number: 15707 --ELM1117481883-4136-3_ Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII S Murthy Kambhampaty wrote: > In postgresql 8.0, "create table <> as ..." statements > appear not to logged unless log_statement = 'all' in > postgresql.conf. We are trying to reduce noise in the > logs from pgAdminIII and phpPgAdmin, but we use a lot > of 'create table <> as ...' queries that need to be > logged, and their duration tracked. Is there a > combination of settings that will do the trick? Can > postgresql be upgraded to log "create table <> as ..." > statements with log_statment = 'ddl' and/or > log_statment = 'mod'? Ah, I see I forgot about SELECT INTO when doing this for 8.0. The attached patch fixes it. I will apply it to 8.0.X and CVS current. Thanks for the report. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 --ELM1117481883-4136-3_ Content-Transfer-Encoding: 7bit Content-Type: text/plain Content-Disposition: inline; filename="/pgpatches/logstmt" Index: src/backend/tcop/postgres.c =================================================================== RCS file: /cvsroot/pgsql/src/backend/tcop/postgres.c,v retrieving revision 1.444 diff -c -c -r1.444 postgres.c *** src/backend/tcop/postgres.c 24 May 2005 04:18:04 -0000 1.444 --- src/backend/tcop/postgres.c 30 May 2005 19:37:09 -0000 *************** *** 498,504 **** if (IsA(parsetree, PrepareStmt)) parsetree = (Node *) (((PrepareStmt *) parsetree)->query); ! if (IsA(parsetree, SelectStmt)) continue; /* optimization for frequent command */ if (log_statement == LOGSTMT_MOD && --- 498,505 ---- if (IsA(parsetree, PrepareStmt)) parsetree = (Node *) (((PrepareStmt *) parsetree)->query); ! if (IsA(parsetree, SelectStmt) && ! ((SelectStmt *) parsetree)->into == NULL) continue; /* optimization for frequent command */ if (log_statement == LOGSTMT_MOD && *************** *** 514,519 **** --- 515,521 ---- if ((log_statement == LOGSTMT_MOD || log_statement == LOGSTMT_DDL) && (strncmp(commandTag, "CREATE ", strlen("CREATE ")) == 0 || + IsA(parsetree, SelectStmt) || /* SELECT INTO, CREATE AS */ strncmp(commandTag, "ALTER ", strlen("ALTER ")) == 0 || strncmp(commandTag, "DROP ", strlen("DROP ")) == 0 || IsA(parsetree, GrantStmt) || /* GRANT or REVOKE */ --ELM1117481883-4136-3_--