Received: from makus.postgresql.org ([98.129.198.125]) by malur.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1TGAak-0002RO-2X for pgsql-hackers@postgresql.org; Mon, 24 Sep 2012 15:29:02 +0000 Received: from momjian.us ([72.94.173.45]) by makus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1TGAai-00057i-Ty for pgsql-hackers@postgresql.org; Mon, 24 Sep 2012 15:29:01 +0000 Received: from bruce by momjian.us with local (Exim 4.72) (envelope-from ) id 1TGAah-0002tM-2I; Mon, 24 Sep 2012 11:28:59 -0400 Date: Mon, 24 Sep 2012 11:28:59 -0400 From: Bruce Momjian To: Peter Eisentraut Cc: Tom Lane , Rural Hunter , PostgreSQL-development Subject: Re: [ADMIN] pg_upgrade from 9.1.3 to 9.2 failed Message-ID: <20120924152859.GG21242@momjian.us> References: <20120918232239.GA2014@momjian.us> <505C307E.20501@gmail.com> <1348403628.18490.1.camel@vanquo.pezone.net> <505F1A98.9090901@gmail.com> <1348440393.18490.2.camel@vanquo.pezone.net> <20120924125500.GA21242@momjian.us> <50605ABC.1000304@gmx.net> <20120924130820.GB21242@momjian.us> <14327.1348496025@sss.pgh.pa.us> <50607B14.1000906@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50607B14.1000906@gmx.net> User-Agent: Mutt/1.5.20 (2009-06-14) X-Pg-Spam-Score: -2.7 (--) X-Archive-Number: 201209/892 X-Sequence-Number: 213920 On Mon, Sep 24, 2012 at 11:24:04AM -0400, Peter Eisentraut wrote: > On 9/24/12 10:13 AM, Tom Lane wrote: > > FWIW, what I found out last time I touched this code is that on many > > systems setlocale doesn't bother to return a canonicalized spelling; > > it just gives back the string you gave it. It might be worth doing > > what Peter suggests, just to be consistent with what we are doing > > elsewhere, but I'm not sure how much it will help. > > It might not have anything to do with the current problem, but if initdb > canonicalizes locale names, then pg_upgrade also has to. Otherwise, > whenever an operating system changes its locale canonicalization rules, > pg_upgrade will fail. Agreed. I will work on that soon. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +