Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M272031=pgsql-hackers-arkari@postgresql.org>)
 id 1YmjK4-0006O2-LD
 for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Apr 2015 13:43:44 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M272031=pgsql-hackers-arkari@postgresql.org>)
 id 1YmjK2-0000q0-34
 for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Apr 2015 13:43:42 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
 by malur.postgresql.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA256:256)
 (Exim 4.80) (envelope-from <andres@anarazel.de>) id 1YmjK0-0000pu-Sq
 for pgsql-hackers@postgresql.org; Mon, 27 Apr 2015 13:43:41 +0000
Received: from mail.anarazel.de ([217.115.131.40])
 by makus.postgresql.org with esmtp (Exim 4.84)
 (envelope-from <andres@anarazel.de>) id 1YmjJp-0002FW-8r
 for pgsql-hackers@postgresql.org; Mon, 27 Apr 2015 13:43:39 +0000
Received: from intern.anarazel.de (x55b39290.dyn.telefonica.de
 [85.179.146.144]) (Authenticated sender: andres@anarazel.de)
 by mail.anarazel.de (Postfix) with ESMTPSA id 87A77860001;
 Mon, 27 Apr 2015 15:43:26 +0200 (CEST)
Date: Mon, 27 Apr 2015 15:43:25 +0200
From: Andres Freund <andres@anarazel.de>
To: Peter Geoghegan <pg@heroku.com>
Cc: hlinnaka <hlinnaka@iki.fi>, Jeff Janes <jeff.janes@gmail.com>,
 Stephen Frost <sfrost@snowman.net>,
 Dean Rasheed <dean.a.rasheed@gmail.com>, Bruce Momjian <bruce@momjian.us>,
 Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0
Message-ID: <20150427134325.GC7296@alap3.anarazel.de>
References: 
 <CAM3SWZTGE0z5_E8wRi9wt3qgOiMpSwtwr5uDcZDGhRZ1_pz6vg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAM3SWZTGE0z5_E8wRi9wt3qgOiMpSwtwr5uDcZDGhRZ1_pz6vg@mail.gmail.com>
X-Pg-Spam-Score: -2.7 (--)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 2015-04-26 18:02:06 -0700, Peter Geoghegan wrote:
> It's make-or-break time for this patch. Please help me get it over the
> line in time.

Could you please add the tests for the logical decoding code you added?
I presume you have some already/

> Heikki is in Northern California this week, and I think
> we'll have time to talk about the patch

I'll be there for a while as well. Starting the week after, arriving on
the 5th. ;)

Greetings,

Andres Freund

-- 
 Andres Freund	                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers