Date: Fri, 8 May 2015 20:35:04 +0200
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@heroku.com>, Heikki Linnakangas <hlinnaka@iki.fi>,
 Jeff Janes <jeff.janes@gmail.com>, Stephen Frost <sfrost@snowman.net>,
 Dean Rasheed <dean.a.rasheed@gmail.com>, Bruce Momjian <bruce@momjian.us>,
 Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0
Message-ID: <20150508183504.GU12950@alap3.anarazel.de>
References: 
 <CAM3SWZTGE0z5_E8wRi9wt3qgOiMpSwtwr5uDcZDGhRZ1_pz6vg@mail.gmail.com>
 <20150508150340.GJ12950@alap3.anarazel.de>
 <9096.1431102730@sss.pgh.pa.us>
 <20150508165246.GO12950@alap3.anarazel.de>
 <10633.1431105922@sss.pgh.pa.us> <554CF44B.3080808@iki.fi>
 <20150508180636.GR12950@alap3.anarazel.de>
 <CAM3SWZQsh=uDmyRW4NzYqU_kv8qAsvCYpJuuYSuikfuJbLANQQ@mail.gmail.com>
 <20150508181445.GS12950@alap3.anarazel.de>
 <17473.1431109846@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <17473.1431109846@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 2015-05-08 14:30:46 -0400, Tom Lane wrote:
> Maybe just hold an open transaction in another session while you do what
> the regression test does?  I think this is probably not a matter of CCA
> per se but just timing.  It's unfortunate that the test in question is
> run serially without other transactions occurring concurrently, as that
> would likely have exposed the problem far sooner.

I think Peter (on IM) just found a more likely explanation than mine.

			index_close(idxRel, NoLock);
			heap_close(relation, NoLock);
			candidates = lappend_oid(candidates, idxForm->indexrelid);
...

Yes. idxForm points into idxRel->rd_index.

He's working on a fix for both this and removal of the still unnecessary
indcheckxmin check.

Greetings,

Andres Freund


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers