Date: Mon, 8 Feb 2016 15:42:06 -0500
From: Stephen Frost <sfrost@snowman.net>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Joe Conway <mail@joeconway.com>, Andres Freund <andres@anarazel.de>,
 Evan Rempel <erempel@uvic.ca>, pgsql-admin@postgresql.org,
 Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [ADMIN] 9.5 new setting "cluster name" and logging
Message-ID: <20160208204206.GV3331@tamriel.snowman.net>
References: <1377186808.57546.YahooMailNeo@web193505.mail.sg3.yahoo.com>
 <A737B7A37273E048B164557ADEF4A58B17C08086@ntex2010a.host.magwien.gv.at>
 <1377494614.9111.YahooMailNeo@web193506.mail.sg3.yahoo.com>
 <A737B7A37273E048B164557ADEF4A58B17C0876C@ntex2010a.host.magwien.gv.at>
 <56AC5601.5040208@uvic.ca>
 <20160208142429.5by57csmc75gorg7@alap3.anarazel.de>
 <56B8C2B9.8020009@joeconway.com>
 <CAEepm=3vqzfOuPa=L-qQWuHE5FJWJoWQc3N6aGS_-70Bz1oo8Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="qqF1XwZUdAkx0x+N"
Content-Disposition: inline
In-Reply-To: 
 <CAEepm=3vqzfOuPa=L-qQWuHE5FJWJoWQc3N6aGS_-70Bz1oo8Q@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--qqF1XwZUdAkx0x+N
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Thomas,

* Thomas Munro (thomas.munro@enterprisedb.com) wrote:
> On Tue, Feb 9, 2016 at 5:30 AM, Joe Conway <mail@joeconway.com> wrote:
> > On 02/08/2016 06:24 AM, Andres Freund wrote:
> >> On 2016-01-29 22:19:45 -0800, Evan Rempel wrote:
> >>> Now that there is a setting to give a cluster a "name", it would be n=
ice to
> >>> have an escape sequence in the log_line_prefix setting that could ref=
erence
> >>> the cluster_name.
> >>
> >> I've argued[1][2] for this when cluster_name was introduced, but back
> >> then I seemed to have been the only one arguing for it. Josh later
> >> jumped that train.
> >>
> >> Given that we now had a number of people wishing for this, can we maybe
> >> reconsider?
> >
> > Seems like a reasonable idea to me. But if we add a log_line_prefix
> > setting, shouldn't we also add it to csvlog output too?
>=20
> Here's a tiny patch adding support for %C to log_line_prefix (this was
> part of the cluster_name patch that didn't go it).
>=20
> Given that csvlog's output format is hardcoded in write_csvlog, how is
> it supposed to evolve without upsetting consumers of this data?
> Wouldn't we first need to add a GUC that lets you control the columns
> it outputs?

Not sure if you really want to go there, but I do agree with you and
there's a thread from a few years back about something similar:

http://www.postgresql.org/message-id/flat/20110112142345.GA4933@tamriel.sno=
wman.net

Included in that thread is a patch, which likely requires some dusting
off, to add exactly that ability.

Thanks!

Stephen

--qqF1XwZUdAkx0x+N
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJWuP2eAAoJEO1sijiDR2RVwbQP/2073kr5vVE/UREmrrq/M4py
oaLl3smw9Uqj/WVBiF+rBUBD4xKAsGgXEmaNVHV6d8+/3I3YuFliJmabE0VsdprK
MZtXc3fufkchzMRBCrdPmWzUy1jvJx+KQ8qDZq9NX+OjMdK/WndXgI+0TuC+qdGG
J9FEYcPp2YCt6GBP9Yd5z90Op3otpbaL7Me7uhb9tdZ+6ZMkbypo1NzLZ8tS+5Um
6hRu2Zzhc76B3jSTJqsuHVdMwFCXem2YhkFrLiUUMqdhUeL1uGsu0bQnNgTgynf0
JKr54mRub5l035vz+F1+oJw1H3eNNPEDBs61ayrhfBikFITN2HqjBbNj5KM50Ne5
qmHQRKixSW9OfL/YAySBUhl7gRYBw7TFzBbBncDdLkmYqATJtcItGOw6GVhpYYph
yD88CjsokTExF//rJ6U8V3uSKadvZR4hr0MNoAdANRDilB38szzTWrl4NDhbLt6p
GxkzCpu8sKowIoqqHk+C48vvIlsixlCtM4AA15cnljaYEhK2BiWFMcmrVarhQ9cw
pFhgADbMRdwWIKh7+eCY3Mz/x62Zz77Oez33ogyJEKKvAAjC8BJ+sYujMRoJxrPH
ePgMJN+6WjDj9FFx0Y9Bb7RBf+HxLqvx2J7Z+VcVjK6wfgv/fczjmefx0/mrxxAg
+OmRF3qwdGmzChFhOVe9
=uwGj
-----END PGP SIGNATURE-----

--qqF1XwZUdAkx0x+N--