Date: Mon, 17 Oct 2016 18:24:05 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Andres Freund <andres@anarazel.de>, Evan Rempel <erempel@uvic.ca>,
	pgsql-admin@postgresql.org,
	Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [ADMIN] 9.5 new setting "cluster name" and logging
Message-ID: <20161017222405.GA13284@tamriel.snowman.net>
References: <1377186808.57546.YahooMailNeo@web193505.mail.sg3.yahoo.com>
 <A737B7A37273E048B164557ADEF4A58B17C08086@ntex2010a.host.magwien.gv.at>
 <1377494614.9111.YahooMailNeo@web193506.mail.sg3.yahoo.com>
 <A737B7A37273E048B164557ADEF4A58B17C0876C@ntex2010a.host.magwien.gv.at>
 <56AC5601.5040208@uvic.ca>
 <20160208142429.5by57csmc75gorg7@alap3.anarazel.de>
 <CAEepm=3qzm=iROikNJFdjyZD3AJPEr3m_RFcmazBjZrzAVNoHw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="X1gmFB0VGnFkIrKA"
Content-Disposition: inline
In-Reply-To: 
 <CAEepm=3qzm=iROikNJFdjyZD3AJPEr3m_RFcmazBjZrzAVNoHw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--X1gmFB0VGnFkIrKA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Thomas Munro (thomas.munro@enterprisedb.com) wrote:
> On Tue, Feb 9, 2016 at 3:24 AM, Andres Freund <andres@anarazel.de> wrote:
> > (x-posting to -hackers, more relevant audience)
> >
> > On 2016-01-29 22:19:45 -0800, Evan Rempel wrote:
> >> Now that there is a setting to give a cluster a "name", it would be ni=
ce to
> >> have an escape sequence in the log_line_prefix setting that could refe=
rence
> >> the cluster_name.
> >
> > I've argued[1][2] for this when cluster_name was introduced, but back
> > then I seemed to have been the only one arguing for it. Josh later
> > jumped that train.
> >
> > Given that we now had a number of people wishing for this, can we maybe
> > reconsider?
>=20
> +1
>=20
> I missed the part of this conversation that took place on -admin.  I
> agree with Evan Rempel's post over there[1] that it's useful for
> syslog users, and that it's not ideal to have to hijack syslog_ident
> or explicitly copy the name into log_line_prefix.
>=20
> [1] https://www.postgresql.org/message-id/56C64017.7050303%40uvic.ca

I'm with Thomas on this and I disagree that the "csvlog bloat" argument
has merit.  If we're worried about bloat in csv then we should provide a
way for users to control what goes into the csvlog, not argue that
something which is clearly useful be excluded.

There's already a patch out there for adding a way to control what goes
into csvlog and it probably wouldn't be too hard to update it.  I know,
because I wrote it.  I continue to feel that it would be useful to add
and that tools which need to deal with csvlogs should be updated to
handle being told what's in it, just like pgBadger does for our much
more complicated and painful regular log files.  That would remove these
bars to moving forward with more flexibility in log_line_prefix and
csvlog output.

Thanks!

Stephen

--X1gmFB0VGnFkIrKA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJYBU+FAAoJEO1sijiDR2RVz9kQAIvyGZL6s8xcf0jsWLj5AcxV
k6u6RP4njkLHMjY7/I/wcUmbWXhJEvgatIG9BEieE3mB05jr2r52j1m9B/RhGaJj
L03FlvDLtLylRs8fEyBLc+jGvLj66/kiswpjimZG8CWBdUBW2ngwEFNIT1hOR3gI
Wb4dzRSZ25PsHiqj0nnyUetSdGbYCBpt6K4lDviL2jG4v4elBo1rJenrAwOw3c02
ldrIqsSHFQb3EFSpw0sNv2k6F7o1QrQhfr7szdfs5VL9dTxM+S20gEXHRiE7zIt8
OuKLrPjCf0c2tHpOgrnYrMNxQR7E4UV6YXXMVWfWlcDq67SoLrHHuW59qOkDqaqJ
rWUdr59KnakQ46BZDHkCOthXaNwuMuOd2o4vZNQFEZDP+tpH1hf8l8YuIqhaxM1k
deha6LTKFqR8PamSna8D9rYWGi+SSvGrz8Lwb8ChH8RR31yyifMMTwGzaw/D6l51
omMInZYXltqqTe/+DEgJyGz8sjY9iTtk33psm20twzY6bgbINtu6zzaXBQ7w9Yyf
NIKRVYltki79lbRWOm1i2IErYBaLYbo98kRoKG83QwsDPv9sjWASmlE61psm2ABj
SKEUnRzXo2IttQxYpVZ459XvOMKxSs+pKcrCwhe7S8YxIiH+nGAkPkYcZGIePMwj
3aPbrq8D5m4DmnuBWFID
=2B1d
-----END PGP SIGNATURE-----

--X1gmFB0VGnFkIrKA--