Date: Tue, 24 Mar 2020 15:12:38 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Julien Rouhaud <rjuju123@gmail.com>, Justin King <kingpin867@gmail.com>,
	pgsql-general@lists.postgresql.org, kgrittn@gmail.com
Subject: Re: PG12 autovac issues
Message-ID: <20200324061238.GG1836@paquier.xyz>
References: 
 <CAE39h22XLA7A=05RezvcTmEp=A369vRScToP5iLdTwArKiAuoA@mail.gmail.com>
 <20200319235626.wz4b57hbhuuy4w7j@alap3.anarazel.de>
 <CAE39h23xR9F8qbo5vj9+KL1nFnnTaYJrFde0BtWczQy_+De39Q@mail.gmail.com>
 <20200320190317.gdxwzexdfutymqs6@alap3.anarazel.de>
 <20200323152247.GB52612@nol>
 <20200323162303.s7ay5hjdvimtkz6u@alap3.anarazel.de>
 <20200323194725.GC52612@nol>
 <20200323200051.qzyqvnips7o3ai4g@alap3.anarazel.de>
 <20200324052606.GE1836@paquier.xyz>
 <20200324054039.ulrxbzo2ycy7pu5i@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="BXr400anF0jyguTS"
Content-Disposition: inline
In-Reply-To: <20200324054039.ulrxbzo2ycy7pu5i@alap3.anarazel.de>
Precedence: bulk


--BXr400anF0jyguTS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 23, 2020 at 10:40:39PM -0700, Andres Freund wrote:
> On 2020-03-24 14:26:06 +0900, Michael Paquier wrote:
>> Nothing really fancy:
>> - autovacuum_vacuum_cost_delay to 2ms (default of v12, but we used it
>> in v11 as well).
>> - autovacuum_naptime =3D 15s
>> - autovacuum_max_workers =3D 6
>> - log_autovacuum_min_duration =3D 0
>=20
> Oh, so you're also involved in this? I'm starting to get a bit confused
> as to who is reporting what.

Yeah, sort of.  Julien has done a lot of work on that and I have an
access to the data and test beds, so we are just saying the same
things.

> Well, there's no logging of autovacuum launchers that don't do anything
> due to the "skipping redundant" logic, with normal log level. If somehow
> the horizon logic of autovacuum workers gets out of whack with what
> vacuumlazy.c does, then you'd not get any vacuums. But a usage level
> triggered analyze could still happen on such a table, I think.

What surprised me the most is that the same table happened to be
analyzed again and again after the launcher began its blackout.

> While looking at this issue I found a few problems, btw. That seems more
> like a -hackers discussion, so I started:
> https://postgr.es/m/20200323235036.6pje6usrjjx22zv3%40alap3.anarazel.de

Yes, let's discuss there.

> I think I might just have figured out another one...

Ouch.
--
Michael

--BXr400anF0jyguTS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl55pNYACgkQnvQgOdby
QH3Ahw/+NvGV9Gb+seFbz0b2VMiFQouhTyVCcQ/81qQEBlwru50ebUpQ+dtgFSxu
08xCsmG11HcPRVxkV5chF4uq1uvCbht/f+cyEbBSTCAqR1BwtFJeHOtddp9ZXdrj
MjpJNuQZJRy3AfZFDyEgzP/vPkl3djeo3lK3nYd7BYaM+5rXGF7cX1keERTl3doq
290ieqJ88yd9b8inS1vvG96sp2dIGUc3nFiDwRSI2zC23y0+3LfmQYy8PdSer1bL
ZSBKqot3m+wFd1ZSYNwik9LVawfH+mruqEJt2GTJd+Eq7LFJdNvDgPERIXPWwgl1
vf1CZzYh5+enxcP5FBeghWZTi/A6VH4qPsYlex1y5gLTFJrrLF53fYqMu/TZogeT
anmoSLNZMCwnZp1VUsjbeyx5hAX8cHGXW99IAkqCYXOOnm826UWbc5CjiSWrGeQt
hBVJ1NDpclYsg+bjKAnyUYgmkeG/HWQAq6dMEwaVb6+r9Yh+13rEYZK54PK6Crwa
7YeIw09L+ZB2g2qGgwNSPET2E4vRpDMPDjzwzAbQ02pT8Znvj75oegYcWTqorNnb
lhkzQxyHivdKGZbMI53S3LVyixEaNAzzH47MsVINplL4Jtgfhh/5bCmo7CKN/QJ+
zanZRSpbc8BBPl6QV2yE/QjkyRHuLfGpHXeO+KY2Y+jFhGtVVOE=
=YVWT
-----END PGP SIGNATURE-----

--BXr400anF0jyguTS--