Date: Fri, 3 Sep 2021 13:20:59 -0700
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: "Bossart, Nathan" <bossartn@amazon.com>,
	Justin Pryzby <pryzby@telsasoft.com>,
	Magnus Hagander <magnus@hagander.net>,
	Mark Dilger <mark.dilger@enterprisedb.com>,
	Don Seiler <don@seiler.us>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Estimating HugePages Requirements?
Message-ID: <20210903202059.lmtc67pivexfmj3a@alap3.anarazel.de>
References: <20210827184648.d3jbv73pgyccqwkz@alap3.anarazel.de>
 <071DC95B-4CA8-4D2B-BD24-1A66B3EFFE28@amazon.com>
 <20210827193813.oqo5lamvyzahs35o@alap3.anarazel.de>
 <0D1645F3-ADFD-4B2F-9F34-961BDFBB881B@amazon.com>
 <YSmYq5Z4GAf8NzxM@paquier.xyz>
 <20210828035722.GQ26465@telsasoft.com>
 <82E1E183-691F-479E-B661-9BE8EC70BD21@amazon.com>
 <YSyIz86xUwpbP+LU@paquier.xyz>
 <48795AC4-289F-4CDE-88F5-4FD1ED2BD3DD@amazon.com>
 <YS8jgN37QvlrKnzQ@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YS8jgN37QvlrKnzQ@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/20210903202059.lmtc67pivexfmj3a%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2021-09-01 15:53:52 +0900, Michael Paquier wrote:
> Hmm.  I am not sure about the addition of huge_pages_required, knowing
> that we would have shared_memory_size.  I'd rather let the calculation
> part to the user with a scan of /proc/meminfo.

-1. We can easily do better, what do we gain by making the user do this stuff?
Especially because the right value also depends on huge_page_size.

Greetings,

Andres Freund