Date: Tue, 15 Mar 2022 15:44:39 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Magnus Hagander <magnus@hagander.net>
Cc: Michael Paquier <michael@paquier.xyz>,
	"Bossart, Nathan" <bossartn@amazon.com>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	Justin Pryzby <pryzby@telsasoft.com>,
	Andres Freund <andres@anarazel.de>,
	Mark Dilger <mark.dilger@enterprisedb.com>,
	Don Seiler <don@seiler.us>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Estimating HugePages Requirements?
Message-ID: <20220315224439.GA1133771@nathanxps13>
References: <YTgy8PdP1+9s6NBz@paquier.xyz>
 <4cc5b434-b174-9aae-197b-737db6cac4e3@oss.nttdata.com>
 <C35CB94F-D391-4E52-AB08-A726112FA852@amazon.com>
 <YTmLQtpUSK77mlGT@paquier.xyz>
 <YTmMLtoLEAjMuRSm@paquier.xyz>
 <6AE0285D-0917-4C05-B6AA-4AEDD2FCBA52@amazon.com>
 <CABUevEweO_ZxTQox=QoO8e3rZQm9qFVU+zdoQvazTH9F7HpdEQ@mail.gmail.com>
 <20220314173417.GA1020555@nathanxps13>
 <Yi/82cqnpKkZsOjI@paquier.xyz>
 <CABUevExgoKMNveD5SvFWOYA4MQvPkDmGxY7DkVRASJED4gBYog@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="82I3+IH0IqGh5yIs"
Content-Disposition: inline
In-Reply-To: 
 <CABUevExgoKMNveD5SvFWOYA4MQvPkDmGxY7DkVRASJED4gBYog@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220315224439.GA1133771%40nathanxps13>
Precedence: bulk


--82I3+IH0IqGh5yIs
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Mar 15, 2022 at 11:02:37PM +0100, Magnus Hagander wrote:
> I think we're talking about two different things here.
> 
> I think the "avoid extra logging" would be worth seeing if we can
> address for 15.

A simple approach could be to just set log_min_messages to PANIC before
exiting.  I've attached a patch for this.  With this patch, we'll still see
a FATAL if we try to use 'postgres -C' for a runtime-computed GUC on a
running server, and there will be no extra output as long as the user sets
log_min_messages to INFO or higher (i.e., not a DEBUG* value).  For
comparison, 'postgres -C' for a non-runtime-computed GUC does not emit
extra output as long as the user sets log_min_messages to DEBUG2 or higher.

> The "able to run on a live cluster" seems a lot bigger and more scary
> and not 15 material.

+1

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

--82I3+IH0IqGh5yIs
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v2-0001-don-t-emit-shutdown-messages-for-postgres-C-with-.patch"