X-Original-To: pgsql-hackers-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 195CFD1B1D5 for ; Wed, 21 Jul 2004 19:44:04 -0300 (ADT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 86745-10 for ; Wed, 21 Jul 2004 22:44:00 +0000 (GMT) Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by svr1.postgresql.org (Postfix) with ESMTP id 25F6CD1B179 for ; Wed, 21 Jul 2004 19:43:56 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.12.11/8.12.11) with ESMTP id i6LMht2T022836; Wed, 21 Jul 2004 18:43:55 -0400 (EDT) To: Simon Riggs Cc: Mark Kirkwood , pgsql-hackers@postgresql.org Subject: Re: PITR COPY Failure (was Point in Time Recovery) In-reply-to: <1090333455.28049.2917.camel@stromboli> References: <200407141555.i6EFtnk22984@mail.osdl.org> <1089833620.17493.4624.camel@stromboli> <40F5E14A.4090003@coretech.co.nz> <1089875702.17493.5539.camel@stromboli> <40F652C6.4070007@coretech.co.nz> <1089935215.17493.6906.camel@stromboli> <40FA0F93.8010607@coretech.co.nz> <40FC6BF2.5050701@coretech.co.nz> <3607.1090296869@sss.pgh.pa.us> <1090324635.28049.2554.camel@stromboli> <7787.1090327914@sss.pgh.pa.us> <1090329086.28049.2708.camel@stromboli> <13342.1090332035@sss.pgh.pa.us> <1090333455.28049.2917.camel@stromboli> Comments: In-reply-to Simon Riggs message dated "Tue, 20 Jul 2004 15:24:16 +0100" Date: Wed, 21 Jul 2004 18:43:55 -0400 Message-ID: <22835.1090449835@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.0 tagged_above=0.0 required=5.0 tests= X-Spam-Level: X-Archive-Number: 200407/1198 X-Sequence-Number: 56759 Simon Riggs writes: > On Tue, 2004-07-20 at 15:00, Tom Lane wrote: >> Yeah, but the WASTED_SPACE/FILE_HEADER stuff is already pretty ugly, and >> adding two more warts to the code to support it is sticking in my craw. >> I'm thinking it would be cleaner to treat the extra labeling information >> as an extension of the WAL page header. > Sounds like a better solution than scrabbling around at the end of file > with too many edge cases to test properly This is done in CVS tip. Mark, could you retest to verify it's fixed? regards, tom lane