X-Original-To: pgsql-admin-postgresql.org@postgresql.org Received: from localhost (mx1.hub.org [200.46.208.251]) by postgresql.org (Postfix) with ESMTP id 219589FA5DD for ; Fri, 9 Jun 2006 17:08:33 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.208.251]) (amavisd-new, port 10024) with ESMTP id 80758-09 for ; Fri, 9 Jun 2006 17:08:28 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey- Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by postgresql.org (Postfix) with ESMTP id 8DC329FA1A8 for ; Fri, 9 Jun 2006 17:08:28 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.13.6/8.13.6) with ESMTP id k59K8OgE024380; Fri, 9 Jun 2006 16:08:24 -0400 (EDT) To: Jeff Frost cc: pgsql-admin@postgresql.org Subject: Re: pg_dumpall 8.1.4 large objects error In-reply-to: References: <25292.1149650216@sss.pgh.pa.us> <12965.1149871382@sss.pgh.pa.us> Comments: In-reply-to Jeff Frost message dated "Fri, 09 Jun 2006 09:53:04 -0700" Date: Fri, 09 Jun 2006 16:08:24 -0400 Message-ID: <24379.1149883704@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200606/84 X-Sequence-Number: 22046 I wrote: >> This is computing obj_description() redundantly for each pg_largeobject >> chunk. Perhaps there is a memory leak in obj_description() in 7.3.2? Actually, obj_description() is a SQL-language function, and we had horrendous problems with end-of-function-call memory leakage in SQL functions in every version before 7.4. So this is undoubtedly the source of Jeff's problem. Jeff Frost writes: > I'll alter pg_dump and recompile, then give a test. Does pg_dumpall just call > pg_dump or do I need to change it there too? pg_dumpall calls pg_dump, so only one place to fix. I've already committed the fix in CVS, if you'd prefer to use a tested patch. http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.c.diff?r1=1.422.2.3;r2=1.422.2.4 regards, tom lane