From: Tom Lane <tgl@sss.pgh.pa.us>
To: Wells Oliver <wells.oliver@gmail.com>
cc: pgsql-admin <pgsql-admin@postgresql.org>
Subject: Re: Upgrading from 9.6 to 12 and running into cast issues with
 pg_catalog.text()
In-reply-to: 
 <CAOC+FBVkQG2PitVHU6Hjpfrjsdi3w3OywvXmT+d7FSN4eX2FHA@mail.gmail.com>
References: 
 <CAOC+FBVkQG2PitVHU6Hjpfrjsdi3w3OywvXmT+d7FSN4eX2FHA@mail.gmail.com>
Comments: In-reply-to Wells Oliver <wells.oliver@gmail.com>
	message dated "Tue, 29 Oct 2019 20:17:40 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <28391.1572412933.1@sss.pgh.pa.us>
Date: Wed, 30 Oct 2019 01:22:13 -0400
Message-ID: <28392.1572412933@sss.pgh.pa.us>
Precedence: bulk

Wells Oliver <wells.oliver@gmail.com> writes:
> I have some implicit casts such as real to text where they depend on the
> function pg_catalog.text(real) which seems to no longer exist in 12. The
> pg_upgrade failure says:

> Command was: CREATE CAST (real AS "text") WITH FUNCTION
> "pg_catalog"."text"(real) AS IMPLICIT;

Hm, there wasn't any such function in 9.6 either, so I suspect you've
forgotten some critical details about how these casts got created.
But anyway, if you really want that behavior, creating the cast
"WITH INOUT" is probably the best way to do it.

			regards, tom lane