X-Original-To: pgsql-patches-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id AB55A5680F for ; Tue, 15 Mar 2005 05:52:17 +0000 (GMT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 09998-06 for ; Tue, 15 Mar 2005 05:52:06 +0000 (GMT) Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by svr1.postgresql.org (Postfix) with ESMTP id 063A156821 for ; Tue, 15 Mar 2005 05:52:05 +0000 (GMT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.13.1/8.13.1) with ESMTP id j2F5q3SU002964; Tue, 15 Mar 2005 00:52:03 -0500 (EST) To: Bruce Momjian Cc: Bjoern Metzdorf , PostgreSQL-patches Subject: Re: [HACKERS] [ADMIN] invalid multibyte character for locale In-reply-to: <200503150526.j2F5QGw15413@candle.pha.pa.us> References: <200503150526.j2F5QGw15413@candle.pha.pa.us> Comments: In-reply-to Bruce Momjian message dated "Tue, 15 Mar 2005 00:26:16 -0500" Date: Tue, 15 Mar 2005 00:52:03 -0500 Message-ID: <2963.1110865923@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.007 tagged_above=0 required=5 tests=AWL X-Spam-Level: X-Archive-Number: 200503/148 X-Sequence-Number: 14959 Bruce Momjian writes: > Tom Lane wrote: >> Perhaps it would be reasonable to do something like this: >> >> #ifdef USE_WIDE_UPPER_LOWER >> /* >> * use wide char code only when max encoding length > one >> * and we aren't in C locale >> */ >> if (pg_database_encoding_max_length() > 1 && >> !lc_ctype_is_c()) > Tom, is this the fix you were thinking of? Seems like it would be a > good improvement. Please fix the comments not only the code ;-). Other than that, this is exactly what I meant. regards, tom lane