Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 1E0D39F95F3 for ; Sun, 16 Sep 2007 13:36:51 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 41954-07 for ; Sun, 16 Sep 2007 13:36:47 -0300 (ADT) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.5 Received: from rv-out-0910.google.com (rv-out-0910.google.com [209.85.198.187]) by postgresql.org (Postfix) with ESMTP id AF4A59F9497 for ; Sun, 16 Sep 2007 13:36:46 -0300 (ADT) Received: by rv-out-0910.google.com with SMTP id l15so1010640rvb for ; Sun, 16 Sep 2007 09:36:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; bh=XioExAhdCg54JVfpkpe5u+/+2x9eTOxYXR/bp1nHZo8=; b=ZxXtAKVGUU5I0AABzQ1BryXZuqJRTqZ2nZ4zgxSEqTPAvW+tLCJuC4wQ1ppaUkIISqaFfmMPYismMWkh6MNazrbIzajpBbgkyX7pSYCOZqLVwjg+Yjx8jK3j6IF9gieaSCGs4TfXR0N/DtP8rcdcVEciL9qQWeH389pYd/LZskM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=q5XS0Z/qGNiIsBGSyxwRaLjkfjk3qJG6buiDRf8UBF0YswsFv20iOLtovoDWXaS5vM3gHIOf4aOuOaJLxSCfUYZnq7ZPlvmKndHxtqDfBaWh7vOENSyvhZwQouEA0y8w5sLNcbrWqqwceBND8vc5J0SvTk6ih9S4kO8Lfk0yzDA= Received: by 10.142.158.17 with SMTP id g17mr720435wfe.1189960605683; Sun, 16 Sep 2007 09:36:45 -0700 (PDT) Received: by 10.142.90.1 with HTTP; Sun, 16 Sep 2007 09:36:45 -0700 (PDT) Message-ID: <2e78013d0709160936t1eec56e4ycbb17da6be9a9df4@mail.gmail.com> Date: Sun, 16 Sep 2007 22:06:45 +0530 From: "Pavan Deolasee" To: "Tom Lane" Subject: Re: Hmmm ... isn't count_nondeletable_pages all wet? Cc: "Gregory Stark" , pgsql-hackers@postgresql.org In-Reply-To: <5354.1189955695@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_4602_4928364.1189960605670" References: <28916.1189900143@sss.pgh.pa.us> <29644.1189904237@sss.pgh.pa.us> <87fy1fkk6p.fsf@oxford.xeocode.com> <5354.1189955695@sss.pgh.pa.us> X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200709/696 X-Sequence-Number: 107848 ------=_Part_4602_4928364.1189960605670 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On 9/16/07, Tom Lane wrote: > > > Couldn't say. Those two were on my mind because the reporters had > allowed me to troll through their table and index files and verify > that there were indeed multiple index pointers to the same table row, > and yet the index itself did not show any indication of corruption. > I had noticed the "clumping" pattern of the doubly-linked rows in > both cases, but hadn't found an explanation. > > This was a nice catch indeed! I remember we fixed a similar issue with VACUUM FULL few months back. Such issues would become prominent with HOT because of early vacuuming and reuse of tuples. Also unlike current VACUUM which runs exclusively on a table (i.e. no two vacuums are allowed to run on a table simultaneously), HOT makes concurrent pruning and vacuuming of a table possible. In fact, during HOT development and testing cycles, I faced similar race conditions a few times. This is just to keep ourselves aware of the changes introduced by HOT. Hopefully by now we have fixed most of the outstanding bugs in the HOT code (and Tom's eyes would catch the remaining, if any :-)). Fingers crossed. Thanks, Pavan -- Pavan Deolasee EnterpriseDB http://www.enterprisedb.com ------=_Part_4602_4928364.1189960605670 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline

On 9/16/07, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Couldn't say.  Those two were on my mind because the reporters had
allowed me to troll through their table and index files and verify
that there were indeed multiple index pointers to the same table row,
and yet the index itself did not show any indication of corruption.
I had noticed the "clumping" pattern of the doubly-linked rows in
both cases, but hadn't found an explanation.


This was a nice catch indeed! I remember we fixed a similar issue
with VACUUM FULL few months back. Such issues would become
prominent with HOT because of early vacuuming and reuse of
tuples. Also unlike current VACUUM which runs exclusively on a table
(i.e. no two vacuums are allowed to run on a table simultaneously),
HOT makes concurrent pruning and vacuuming of a table possible.

In fact, during HOT development and testing cycles, I faced
similar race conditions a few times. This is just to keep ourselves aware of
the changes introduced by HOT. Hopefully by now we have fixed most of
the outstanding bugs in the HOT code (and Tom's eyes would catch the
remaining, if any :-)). Fingers crossed.

Thanks,
Pavan


--
Pavan Deolasee
EnterpriseDB     http://www.enterprisedb.com ------=_Part_4602_4928364.1189960605670--