pg.ddx.io pgsql-admin@postgresql.org mailing list archive
help / color / mirror / Atom feedDuplicate variable declared?
2+ messages / 2 participants
[nested] [flat]
* Duplicate variable declared?
@ 2004-04-21 04:48 mike g <mike@thegodshalls.com>
2004-04-21 05:23 ` Re: Duplicate variable declared? Joe Conway <mail@joeconway.com>
0 siblings, 1 reply; 2+ messages in thread
From: mike g @ 2004-04-21 04:48 UTC (permalink / raw)
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Hello,
In file postgresql-7.4.2/src/backend/utils/fmgrtab.c
line 336 and line 337 are both equal to "extern Datum array_push
(PG_FUNCTION_ARGS);"
I have created a simple perl script that examines files line by line and
if 2 in a row match prints a result.
Sometimes it catches bad cvs checkins or copy/paste mistakes.
I will continue to scan the output.
Hope this helps.
Mike
On Tue, 2004-04-20 at 22:51, Matthew T. O'Connor wrote:
> Tom Lane wrote:
>
> >"Matthew T. O'Connor" <matthew@zeut.net> writes:
> >
> >
> >>This is a good question, and I would like some opinions from some other
> >>people more informed than I.
> >>
> >>
> >
> >You *can not* vacuum other sessions' temp tables; you don't have access
> >to the data. (You have no way to get at pages that are modified in
> >someone else's local buffer manager.) You could vacuum your own temp
> >tables, if you had any, but I would hardly expect autovacuum to have
> >any.
> >
> >
>
> Ok, so I will change pg_autovacuum to explicitly ignore temp tables.
> Just to be sure, I can do this by avoiding anything found in the pg_temp
> schemea, or is there a better way? Is it possible that a user could or
> would put a non-temp table the pg_temp schemea?
>
> >In reference to Chris' followup question, you *should* be vacuuming
> >system catalogs, and you *should not* be vacuuming TOAST tables. VACUUM
> >on a regular table automatically hits the associated TOAST table.
> >
>
> Ok, this is as I thought, pg_autovacuum is already doing the right thing
> here. (see the post I just sent a few minutes ago for more details).
>
> Thanks Tom,
>
> Matthew
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org
Attachments:
signature.asc (application/pgp-signature, 188B) download
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Duplicate variable declared?
2004-04-21 04:48 Duplicate variable declared? mike g <mike@thegodshalls.com>
@ 2004-04-21 05:23 ` Joe Conway <mail@joeconway.com>
0 siblings, 0 replies; 2+ messages in thread
From: Joe Conway @ 2004-04-21 05:23 UTC (permalink / raw)
To: mike@thegodshalls.com; +Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
mike g wrote:
> In file postgresql-7.4.2/src/backend/utils/fmgrtab.c
This is an automatically generated file. The reason for duplicate
array_push declarations is that one-and-the-same array_push function is
used to implement two SQL functions, array_append and array_prepend. I
don't imagine the duplicate declaration hurts anything.
Joe
> Mike
>
> On Tue, 2004-04-20 at 22:51, Matthew T. O'Connor wrote:
>
>>Tom Lane wrote:
>>>"Matthew T. O'Connor" <matthew@zeut.net> writes:
>>>>This is a good question, and I would like some opinions from some other
>>>>people more informed than I.
p.s. It is generally considered bad form to reply to an existing thread
with an entirely new topic.
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2004-04-21 05:23 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2004-04-21 04:48 Duplicate variable declared? mike g <mike@thegodshalls.com>
2004-04-21 05:23 ` Joe Conway <mail@joeconway.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox