Message-ID: <4CB6DCF1.5060006@lelarge.info>
Date: Thu, 14 Oct 2010 12:35:29 +0200
From: Guillaume Lelarge <guillaume@lelarge.info>
User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); fr;
	rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4
MIME-Version: 1.0
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
CC: Kasia Tuszynska <ktuszynska@esri.com>
Subject: Re: [ADMIN] two questions about pg 9.0
References: 
 <1508171717.69491.1286831195955.JavaMail.root@sz0093a.westchester.pa.mail.comcast.net>
	<7815.1286839244@sss.pgh.pa.us>
	<232B5217AD58584C87019E8933556D1102198CA98C@redmx2.esri.com>
	<4CB4A1F9.60408@lelarge.info>
	<232B5217AD58584C87019E8933556D1102199CC548@redmx2.esri.com>
	<4CB62282.1070408@lelarge.info>
In-Reply-To: <4CB62282.1070408@lelarge.info>
Content-Type: multipart/mixed; boundary="------------060308070908010106050001"

This is a multi-part message in MIME format.
--------------060308070908010106050001
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit

Le 13/10/2010 23:20, Guillaume Lelarge a écrit :
> Le 13/10/2010 22:21, Kasia Tuszynska a écrit :
>> [...]
>> Thanks for your reply I did a bit more testing with the superuser priv issue, and now I came to the conclusion that pgAdminIII may be doing something silly.
>>
> 
> Sure, that happens more than I would like.
> 
>> I created a user: bob
>>
>> In pgAdminIII I checked off the box for: can inherit from parent role, can create db object, superuser
>> Got the following sql: 
>> CREATE ROLE bob LOGIN
>>   ENCRYPTED PASSWORD 'md51e9484aace238e7cb2609130fd87646e'
>>   SUPERUSER INHERIT CREATEDB NOCREATEROLE;
>> UPDATE pg_authid SET rolcapupdate=false WHERE rolname='bob';
>>
>> Than I created bobb
>> In pgAdminIII I checked off the box for: can inherit from parent role, can create db object, superuser, Can modify catalog directly
>> Got the following sql: 
>> CREATE ROLE bobb LOGIN
>>   ENCRYPTED PASSWORD 'md51e9484aace238e7cb2609130fd87646e'
>>   SUPERUSER INHERIT CREATEDB NOCREATEROLE;
>>
>> Conclusion:
>> Sql level superuser = pgAdminIII superuser + can modify catalog directly
>>
>> This is misleading, I would call it a pgAdminIII bug but who knows maybe it is a feature...
>>
> 
> I would not call it a feature. I find this misleading too. I'm too tired
> right now to work on a fix, but it'll be easy and quick to do.
> 
> I have a few things to commit tomorrow. I'll try to work on this at the
> same time.
> 

OK, was really simple to fix. See the patch attached.

Any comments on this patch? I'm ready to commit it on 1.12 and master,
if no-one objects.

Thanks.


-- 
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

--------------060308070908010106050001
Content-Type: text/x-diff;
	name="0001-Fix-the-setting-of-Can-update-catalog-checkbox.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename*0="0001-Fix-the-setting-of-Can-update-catalog-checkbox.patch"


--------------060308070908010106050001--