Received: from makus.postgresql.org ([98.129.198.125])
	by malur.postgresql.org with esmtp (Exim 4.72)
	(envelope-from <peter_e@gmx.net>) id 1TGAW1-0001IM-7P
	for pgsql-hackers@postgresql.org; Mon, 24 Sep 2012 15:24:09 +0000
Received: from eisentraut.org ([85.214.91.16] helo=gattler.pezone.net)
	by makus.postgresql.org with esmtp (Exim 4.72)
	(envelope-from <peter_e@gmx.net>) id 1TGAVz-000533-Pu
	for pgsql-hackers@postgresql.org; Mon, 24 Sep 2012 15:24:08 +0000
Received: from jesse.mybdev.com (unknown [204.145.120.11])
	by gattler.pezone.net (Postfix) with ESMTPSA id 49D465A8017;
	Mon, 24 Sep 2012 15:24:05 +0000 (UTC)
Message-ID: <50607B14.1000906@gmx.net>
Date: Mon, 24 Sep 2012 11:24:04 -0400
From: Peter Eisentraut <peter_e@gmx.net>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
	rv:15.0) Gecko/20120907 Thunderbird/15.0.1
MIME-Version: 1.0
To: Tom Lane <tgl@sss.pgh.pa.us>
CC: Bruce Momjian <bruce@momjian.us>, Rural Hunter <ruralhunter@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [ADMIN] pg_upgrade from 9.1.3 to 9.2 failed
References: <20120917043236.GA20123@momjian.us> <5056AF29.3040903@gmail.com>
	<20120917210723.GA30394@momjian.us>
	<20120918232239.GA2014@momjian.us> <505C307E.20501@gmail.com>
	<1348403628.18490.1.camel@vanquo.pezone.net>
	<505F1A98.9090901@gmail.com>
	<1348440393.18490.2.camel@vanquo.pezone.net>
	<20120924125500.GA21242@momjian.us> <50605ABC.1000304@gmx.net>
	<20120924130820.GB21242@momjian.us>
	<14327.1348496025@sss.pgh.pa.us>
In-Reply-To: <14327.1348496025@sss.pgh.pa.us>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Pg-Spam-Score: -1.9 (-)
X-Archive-Number: 201209/891
X-Sequence-Number: 213919

On 9/24/12 10:13 AM, Tom Lane wrote:
> FWIW, what I found out last time I touched this code is that on many
> systems setlocale doesn't bother to return a canonicalized spelling;
> it just gives back the string you gave it.  It might be worth doing
> what Peter suggests, just to be consistent with what we are doing
> elsewhere, but I'm not sure how much it will help.

It might not have anything to do with the current problem, but if initdb
canonicalizes locale names, then pg_upgrade also has to.  Otherwise,
whenever an operating system changes its locale canonicalization rules,
pg_upgrade will fail.