Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ey0yI-0003tl-Cj for pgsql-hackers@arkaria.postgresql.org; Mon, 19 Mar 2018 20:01:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ey0yH-0002oz-2m for pgsql-hackers@arkaria.postgresql.org; Mon, 19 Mar 2018 20:01:29 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ey0yG-0002oq-Og for pgsql-hackers@lists.postgresql.org; Mon, 19 Mar 2018 20:01:28 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ey0yE-0008CH-4S for pgsql-hackers@lists.postgresql.org; Mon, 19 Mar 2018 20:01:27 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w2JK1LPm005851; Mon, 19 Mar 2018 16:01:21 -0400 From: Tom Lane To: Andres Freund cc: Terry Phelps , pgsql-hackers@lists.postgresql.org Subject: Re: Compile error while building postgresql 10.3 In-reply-to: <20180319195451.vxymrucrnxwpbzw3@alap3.anarazel.de> References: <13506.1521487746@sss.pgh.pa.us> <28853.1521489010@sss.pgh.pa.us> <20180319195451.vxymrucrnxwpbzw3@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Mon, 19 Mar 2018 12:54:51 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <5849.1521489681.1@sss.pgh.pa.us> Date: Mon, 19 Mar 2018 16:01:21 -0400 Message-ID: <5850.1521489681@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Andres Freund writes: > There seems to be something sketchy afoot here, even outside of > CFLAGS_SSE42 itself. From the original email: > cc -I/usr/local/include -I../../src/port -DFRONTEND -I../../src/include > -c -o pg_crc32c_sse42.o pg_crc32c_sse42.c > isn't this missing a number of important flags? Like at least > -fno-strict-aliasing -fwrapv -fexcess-precision=standard? Good point ... seems like we lost *all* CFLAGS not just the SSE42 ones. I believe the options we see here are all from CPPFLAGS not CFLAGS. Terry, could we see a full "make" trace from src/port/? Something like cd src/port make -s clean make I'm curious whether the flags lossage affects all .c files in that directory, or only ones that are trying to add on custom flags. regards, tom lane