To: "Kevin Grittner" <Kevin.Grittner@wicourts.gov>
cc: zhouqq@cs.toronto.edu, icub3d@gmail.com, pgsql-admin@postgresql.org
Subject: Re: ERROR: could not read block 
In-reply-to: <437AFF650200002500000762@gwmta.wicourts.gov> 
References: <437AFF650200002500000762@gwmta.wicourts.gov>
Comments: In-reply-to "Kevin Grittner" <Kevin.Grittner@wicourts.gov>
	message dated "Wed, 16 Nov 2005 09:44:04 -0600"
Date: Wed, 16 Nov 2005 11:08:30 -0500
Message-ID: <6302.1132157310@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>

"Kevin Grittner" <Kevin.Grittner@wicourts.gov> writes:
> Is there anything you would like me to include in my build for my
> test runs, or any steps you would like me to take during the tests?

You might want to insert some debugging elog's into mdread() in md.c,
rather than in its caller smgrread.  I'm concerned that by the time
control comes back to smgrread, the Windows last-error might have
been changed; in any case, we'd not know exactly which of the steps
in mdread failed.  I'd suggest something like

	if (FileSeek(v->mdfd_vfd, seekpos, SEEK_SET) != seekpos)
+	{
+		elog(LOG, "seek failed on relation %u/%u/%u: %d",
+		     reln->smgr_rnode.spcNode,
+		     reln->smgr_rnode.dbNode,
+		     reln->smgr_rnode.relNode,
+		     GetLastError());
		return false;
+	}

	status = true;
	if ((nbytes = FileRead(v->mdfd_vfd, buffer, BLCKSZ)) != BLCKSZ)
	{
+		elog(LOG, "read failed on relation %u/%u/%u: %d bytes, %d",
+		     reln->smgr_rnode.spcNode,
+		     reln->smgr_rnode.dbNode,
+		     reln->smgr_rnode.relNode,
+		     nbytes,
+		     GetLastError());
		/*
		 * If we are at or past EOF, return zeroes without complaining. Also
		 * substitute zeroes if we found a partial block at EOF.

(untested, but something like this should do it)

			regards, tom lane