From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Wells Oliver <wells.oliver@gmail.com>, Stephen Frost <sfrost@snowman.net>,
        pgsql-admin <pgsql-admin@postgresql.org>
Subject: Re: Odd pg dump error: cache lookup failure
In-reply-to: <20201023185144.GA16041@alvherre.pgsql>
References: <20201023185144.GA16041@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Fri, 23 Oct 2020 15:51:44 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <737422.1603734778.1@sss.pgh.pa.us>
Date: Mon, 26 Oct 2020 13:52:58 -0400
Message-ID: <737423.1603734778@sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> [ v3 patches ]

This looks committable to me, with one trivial nit:
in LockViewRecurse_walker, it'd be better to not do get_rel_name()
(or even fetch rte->relid, really) until we've verified the rtekind.
As-is, it's wasting cycles and presuming more than it ought to
about the error behavior of get_rel_name().  That's a pre-existing
problem not the fault of this patch, but we might as well fix it
while we're here.

			regards, tom lane