Received: from malur.postgresql.org ([2a02:16a8:dc51::56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1flidD-0005kq-Ny
	for pgsql-bugs@arkaria.postgresql.org; Fri, 03 Aug 2018 22:33:11 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1flidB-0004qw-Pb
	for pgsql-bugs@arkaria.postgresql.org; Fri, 03 Aug 2018 22:33:09 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1flidB-0004qp-G3
	for pgsql-bugs@lists.postgresql.org; Fri, 03 Aug 2018 22:33:09 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1flid7-0003YD-Pq
	for pgsql-bugs@lists.postgresql.org; Fri, 03 Aug 2018 22:33:08 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w73MWvGH007665;
	Fri, 3 Aug 2018 18:32:57 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
cc: Andres Freund <andres@anarazel.de>,
        Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
        Mario De Frutos Dieguez <mariodefrutos@gmail.com>,
        pgsql-bugs@lists.postgresql.org
Subject: Re: Fwd: Problem with a "complex" upsert
In-reply-to: 
 <CAEZATCViZQcByymBpdWY2pXKHpvoX4ZN+G+KhAMEi=w3fwRnDA@mail.gmail.com>
References: 
 <CAFYwGJ0xfzy8jaK80hVN2eUWr6huce0RU8AgU04MGD00igqkTg@mail.gmail.com>
 <CAFYwGJ3Cpb2T+177rEopU7_aQE3W03UoqNZXdP5erCtSRgDGVA@mail.gmail.com>
 <18795.1529600753@sss.pgh.pa.us>
 <8da3739d-da24-1125-cab6-b68d6ec1bc6a@lab.ntt.co.jp>
 <30415.1531256373@sss.pgh.pa.us>
 <4b956567-8283-1b8a-7cd7-f8b6e626bba9@lab.ntt.co.jp>
 <CAEZATCWqLba_VVT1cdaT3YOijESRT8qewLN93Oc7H7ikW2fd-Q@mail.gmail.com>
 <CAEZATCUzdUerONYpaZ-YTVKOyzm1B-Ya9XzFXoMs0yrwJr0hkw@mail.gmail.com>
 <20180803184638.gdii7mja7qfc3fba@alap3.anarazel.de>
 <CAEZATCViZQcByymBpdWY2pXKHpvoX4ZN+G+KhAMEi=w3fwRnDA@mail.gmail.com>
Comments: In-reply-to Dean Rasheed <dean.a.rasheed@gmail.com>
	message dated "Fri, 03 Aug 2018 22:26:11 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7663.1533335577.1@sss.pgh.pa.us>
Date: Fri, 03 Aug 2018 18:32:57 -0400
Message-ID: <7664.1533335577@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Precedence: bulk

Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> On 3 August 2018 at 19:46, Andres Freund <andres@anarazel.de> wrote:
>> Are you planning to push a version of this soon? It'd be good to
>> get this included in the next set of releases...

> Yes, agreed. I'll try to do it this weekend.

Keep in mind that we are hard up against the release deadline.
This is a bad weekend to be pushing anything you are not 100.00%
sure of; the later, the more so, as by Sunday you will probably not
get a complete set of buildfarm reports before the wrap happens.

Balance the risks of shipping a broken release vs. waiting one
more quarter to ship the fix.  After a quick look at the size
of the patch, my own inclination if I were the committer would
be to wait till after the releases are out.  Or you might
consider pushing only to 11+HEAD, with the expectation of
back-patching later after we've gotten some beta results.

			regards, tom lane