From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ron <ronljohnsonjr@gmail.com>
cc: pgsql-admin@lists.postgresql.org
Subject: Re: TIL: In pg_dump, beware the combo of "-Fd" and "-Z"
In-reply-to: <d68bd2ad-f9ba-21e0-6b32-da9e4476b008@gmail.com>
References: <1ad81a44-b39e-5854-ba82-0bd1b61bef25@gmail.com>
 <CAKFQuwYcWQP=G45=oTHkXa5f2EN_emSJbAy1chOg+hTd_wrjmg@mail.gmail.com>
 <267c0d6d-6a02-4c3a-b928-75472ce66de0@gmail.com>
 <249144ee-e91c-adfb-bcfa-dc1c5462e0c4@03s.net>
 <d68bd2ad-f9ba-21e0-6b32-da9e4476b008@gmail.com>
Comments: In-reply-to Ron <ronljohnsonjr@gmail.com>
	message dated "Tue, 19 Jan 2021 23:37:26 -0600"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <784981.1611174438.1@sss.pgh.pa.us>
Date: Wed, 20 Jan 2021 15:27:18 -0500
Message-ID: <784982.1611174438@sss.pgh.pa.us>
Precedence: bulk

Ron <ronljohnsonjr@gmail.com> writes:
> On 1/19/21 10:54 PM, Adrian Ho wrote:
>> A quick look at the `pg_dump` source code indicates that:
>> 
>> * `-Z` requires an argument, and
>> 
>> * the argument is converted to an integer with the `atoi()` C function
>> 
>> This means that `-Z` actually took `-v` as its argument, which `atoi()` 
>> converts to integer 0. That explains what you saw, and I'm also guessing 
>> you did NOT get verbose output from your second command.

> That's right.

Using atoi or siblings without any error checking is not unusual in our
programs (or lots of others, I imagine).  I recall some past discussion
of tightening up parsing of integer arguments to complain if they
didn't look like integers.  But evidently nobody's pushed that forward.

			regards, tom lane